-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added aria-live as a alias for accessibility-live-region #34555
feat: added aria-live as a alias for accessibility-live-region #34555
Conversation
Hi @mayank-96! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 98d84e5 |
Base commit: 62f83a9 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…s-for-accessibility-live-region
Hello @necolas, Let me know if anything else needs to be done here. |
…s-for-accessibility-live-region
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…s-for-accessibility-live-region
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @mayank-96 in 7ea54a4. When will my fix make it into a release? | Upcoming Releases |
…ook#34555) Summary: This adds `aria-live` alias for `accessibilityLiveRegion`, it unifies aria-live and accessibilityLiveRegion and also maps `aria-live='off'` to `accessibilityLiveRegion='none'` as requested on facebook#34424 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General][Added] - Added aria-live alias for accessibilityLiveRegion. Pull Request resolved: facebook#34555 Test Plan: ```js <View aria-live="polite"> <Text>Clicked {this.state.count} times</Text> </View> <View aria-live="off"> <Text>Clicked {this.state.count} times</Text> </View> ``` Reviewed By: cipolleschi Differential Revision: D39206291 Pulled By: jacdebug fbshipit-source-id: fd2019e7047ff7ff6133fed39f1a70b5a9396f89
Summary
This adds
aria-live
alias foraccessibilityLiveRegion
, it unifies aria-live and accessibilityLiveRegion and also mapsaria-live='off'
toaccessibilityLiveRegion='none'
as requested on #34424Changelog
[General][Added] - Added aria-live alias for accessibilityLiveRegion.
Test Plan