Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aria-disabled aliasing for button #34521

Conversation

ankit-tailor
Copy link
Contributor

@ankit-tailor ankit-tailor commented Aug 28, 2022

Summary

This adds the aria-disabled prop to the Button component where it's used as requested on #34424, mapping web aria-disabled to equivalent accessibilityState

Changelog

[General] [Added] - Add aria-disabled prop to Button component

[CATEGORY] [TYPE] - Message

Test Plan

<Button
  aria-disabled={true}
  onPress={() => onButtonPress('submitted')}
  testID="accessibilityState_button"
  color={theme.LinkColor}
  title="Submit Application"
  accessibilityLabel="Press to submit your application!"
/>

@facebook-github-bot
Copy link
Contributor

Hi @ankit-tailor!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 28, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 28, 2022
Copy link
Contributor

@necolas necolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is limited only to Button (which is a component we intend to deprecate anyway), rather than generally being an alias for accessibilityState.disabled

@ankit-tailor
Copy link
Contributor Author

Hi @necolas, I'll add it for core components. I just wanted to know if this is the correct way.

@necolas
Copy link
Contributor

necolas commented Aug 29, 2022

Looks reasonable to me given how accessibilityState was working

@ankit-tailor
Copy link
Contributor Author

Then I'll create another PR having all accessibility states aliasing for core components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants