-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tabIndex prop to View component #34486
feat: Add tabIndex prop to View component #34486
Conversation
0f35a0d
to
7fea932
Compare
Base commit: ed21a3e |
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
7fea932
to
4b11bd8
Compare
@necolas I've just rebased it now that CI has been fixed |
Base commit: ed21a3e |
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dc7a62b
to
3d2d515
Compare
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @gabrieldonadel in 621f4cf. When will my fix make it into a release? | Upcoming Releases |
Summary
This adds the
tabIndex
Android only prop to View as requested on #34424 mapping the existingfocusable
prop totabIndex
so thattabIndex={0}
maps tofocusable={true}
andtabIndex={-1}
representsfocusable={false}
.Changelog
[Android] [Added] - Add tabIndex prop to View component
Test Plan
I'm still investigating the best way to test this but we're are just mapping this to an existing prop