Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tabIndex prop to View component #34486

Closed

Conversation

gabrieldonadel
Copy link
Collaborator

Summary

This adds the tabIndex Android only prop to View as requested on #34424 mapping the existing focusable prop to tabIndex so that tabIndex={0} maps to focusable={true} and tabIndex={-1} represents focusable={false}.

Changelog

[Android] [Added] - Add tabIndex prop to View component

Test Plan

I'm still investigating the best way to test this but we're are just mapping this to an existing prop

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 23, 2022
@react-native-bot react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Aug 23, 2022
@gabrieldonadel gabrieldonadel force-pushed the feat/add-tab-index-to-view branch 2 times, most recently from 0f35a0d to 7fea932 Compare August 23, 2022 19:23
@analysis-bot
Copy link

analysis-bot commented Aug 23, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,617,967 +95
android hermes armeabi-v7a 7,032,206 +87
android hermes x86 7,918,045 +114
android hermes x86_64 7,891,666 +118
android jsc arm64-v8a 9,495,266 -17
android jsc armeabi-v7a 8,272,879 -35
android jsc x86 9,433,068 -6
android jsc x86_64 10,026,062 -2

Base commit: ed21a3e
Branch: main

@facebook-github-bot
Copy link
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel
Copy link
Collaborator Author

@necolas I've just rebased it now that CI has been fixed

@analysis-bot
Copy link

analysis-bot commented Aug 24, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ed21a3e
Branch: main

@facebook-github-bot
Copy link
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @gabrieldonadel in 621f4cf.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants