Support TypeScript array types for turbo module (component only) #34216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @ZihanChen-MSFT in 33d1291. When will my fix make it into a release? | Upcoming Releases |
dmytrorykun
pushed a commit
that referenced
this pull request
Sep 14, 2022
) Summary: Turbo module codegen for component parse `readonly T[]` and `readonly Object[][]` incorrectly. In this change, it is fixed, with necessary test cases added. ## Changelog [General] [Added] - Support TypeScript array types for turbo module (component only) Pull Request resolved: #34216 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: sammy-SC Differential Revision: D37953004 Pulled By: cipolleschi fbshipit-source-id: b71ea35eb9c4bd5dc41130f1dcf9201704ec298e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turbo module codegen for component parse
readonly T[]andreadonly Object[][]incorrectly. In this change, it is fixed, with necessary test cases added.Changelog
[General] [Added] - Support TypeScript array types for turbo module (component only)
Test Plan
yarn jestpassed inpackages/react-native-codegen