Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(android): bump soloader to 0.10.4 #34213

Closed
wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Contributor

Summary

soloader 0.10.3 will apparently cause crashes in instrumented tests, 0.10.4 appears to fix these crashes

Related: facebook/SoLoader#94
Related: reactwg/react-native-releases#26 (comment)

Changelog

[Android] [Changed] - Bump Soloader to 0.10.4

Test Plan

This is hard to test since it's in the AAR etc., I'm hoping CI is sufficient as the previous soloader bump PR went through similarly

soloader 0.10.3 will apparently cause crashes in instrumented tests, 0.10.4 appears to fix these crashes

Related: facebook/SoLoader#94
Related: reactwg/react-native-releases#26 (comment)
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Sony Partner: Sony Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 18, 2022
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jul 18, 2022
@kelset kelset requested a review from cortinico July 18, 2022 17:32
@kelset kelset removed the p: Sony Partner: Sony label Jul 18, 2022
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mikehardy in b9adf2d.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 19, 2022
@mikehardy mikehardy deleted the @mikehardy/soloader-0.10.4 branch July 19, 2022 21:59
kelset pushed a commit that referenced this pull request Jul 27, 2022
Summary:
soloader 0.10.3 will apparently cause crashes in instrumented tests, 0.10.4 appears to fix these crashes

Related: facebook/SoLoader#94
Related: reactwg/react-native-releases#26 (comment)

## Changelog

[Android] [Changed] - Bump Soloader to 0.10.4

Pull Request resolved: #34213

Test Plan: This is hard to test since it's in the AAR etc., I'm hoping CI is sufficient as the previous soloader bump PR went through similarly

Reviewed By: cipolleschi

Differential Revision: D37960320

Pulled By: cortinico

fbshipit-source-id: ce1611d7b30df737c8525a70839b5491a6585c75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants