fix: remove deprecated removeListener methods #33580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
update example app reference: facebook#32526 (comment)
matinzd
force-pushed
the
fix/remove_deprecated_remove_listener_method
branch
from
da24585
to
ed34ab6
Compare
facebook-github-bot
added
the
Shared with Meta
Base commit: 61b013e |
Base commit: 61b013e |
|
/cc @cortinico |
packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js
Outdated
Show resolved
Hide resolved
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @matinzd in 2596b2f. When will my fix make it into a release? | Upcoming Releases |
Merged
12 tasks
This was referenced Jul 23, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
Summary: We are already returning the `remove` function, and the `removeEventListener` method has been removed in this PR: #33580. So I believe this comment is now outdated and no longer relevant. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Removed] - Remove outdated TODO in AppState Pull Request resolved: #34264 Reviewed By: dmitryrykun Differential Revision: D38120344 Pulled By: GijsWeterings fbshipit-source-id: c6c4d42f5b631a67bb6ad49c14df1a772f1cc71b
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
…nking mocks (#34260) Summary: The removeEventListener method has been removed from AccessibilityInfo and Linking in this PR: #33580, so I believe we can remove it from the mocks. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Removed] - Remove removeEventListener from AccessibilityInfo and Linking mocks Pull Request resolved: #34260 Test Plan: I executed jest and everything is still green. Reviewed By: dmitryrykun Differential Revision: D38198653 Pulled By: GijsWeterings fbshipit-source-id: 72d10ca54cd505d7c76e7531c9df718b1a9b9ed1
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…nking mocks (facebook#34260) Summary: The removeEventListener method has been removed from AccessibilityInfo and Linking in this PR: facebook#33580, so I believe we can remove it from the mocks. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Removed] - Remove removeEventListener from AccessibilityInfo and Linking mocks Pull Request resolved: facebook#34260 Test Plan: I executed jest and everything is still green. Reviewed By: dmitryrykun Differential Revision: D38198653 Pulled By: GijsWeterings fbshipit-source-id: 72d10ca54cd505d7c76e7531c9df718b1a9b9ed1
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…nking mocks (facebook#34260) Summary: The removeEventListener method has been removed from AccessibilityInfo and Linking in this PR: facebook#33580, so I believe we can remove it from the mocks. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Removed] - Remove removeEventListener from AccessibilityInfo and Linking mocks Pull Request resolved: facebook#34260 Test Plan: I executed jest and everything is still green. Reviewed By: dmitryrykun Differential Revision: D38198653 Pulled By: GijsWeterings fbshipit-source-id: 72d10ca54cd505d7c76e7531c9df718b1a9b9ed1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove old deprecated modules that cause annoying warnings. This can be a breaking change for some third-party modules.
Changelog
[General] [Removed] - Remove deprecated removeListener methods
Test Plan