Consume Fbjni via Prefab #33397
Closed
Consume Fbjni via Prefab #33397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently, we're consuming Fbjni by copying over the .so and .h files from the Android Archive. This adds unnecessary complexity and can be simplified by consuming them via prefab Changelog: [Internal] [Changed] - Cosnume Fbjni via Prefab Reviewed By: ShikaSD Differential Revision: D34684840 fbshipit-source-id: f4539c7752729cb887ba06119deff10325e206d4
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34684840 |
Base commit: e97e349 |
Base commit: e97e349 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
cortinico
removed
the
Stale
|
Closing as we'll come up with a different approach for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, we're consuming Fbjni by copying over the .so and .h files from the
Android Archive. This adds unnecessary complexity and can be simplified by consuming
them via prefab
Changelog:
[Internal] [Changed] - Cosnume Fbjni via Prefab
Reviewed By: ShikaSD
Differential Revision: D34684840