Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fail-safe check to catch MissingWebViewPackage Exception. #33088

Closed
wants to merge 2 commits into from
Closed

Added fail-safe check to catch MissingWebViewPackage Exception. #33088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b7bda8
Added fail-safe check to catch MissingWebViewPackage Exception.
Kunal-Airtel2022 Feb 11, 2022
20e1fc8
modified the check to combine old and new ones
Kunal-Airtel2022 Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,15 @@ protected void doInBackgroundGuarded(Void... params) {
// We cannot catch MissingWebViewPackageException as it is in a private / system API
// class. This validates the exception's message to ensure we are only handling this
// specific exception.
// The exception class doesn't always contain the correct name as it depends on the OEM
// and OS version. It is better to check the message for clues regarding the exception
// as that is somewhat consistent across OEMs.
// For instance, the Exception thrown on OxygenOS 11 is a RuntimeException but the message contains the required strings.
// https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#348
if (message != null
&& exception.getClass().getCanonicalName().contains("MissingWebViewPackageException")) {
return null;
if (exception.getClass().getCanonicalName().contains("MissingWebViewPackageException") ||
(message!=null && (message.contains("WebView provider") ||
message.contains("No WebView installed")))) {
return null;
} else {
throw exception;
}
Expand Down