-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing sources jar into published android artifacts #32982
Conversation
cc @dulmandakh |
Base commit: 20b9ed9 |
Base commit: 20b9ed9 |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great improvement, thanks for adding it 👍
This pull request was successfully merged by @Kudo in 384e1a0. When will my fix make it into a release? | Upcoming Releases |
thanks @cortinico! |
Summary
when migrated to
maven-publish
in #31611, the sources jar is not included by default frommaven-publish
. so react-native 0.66 / 0.67 doesn't include sources jar in npm published artifacts. it's not ideal for debug or tracing code.this pr added the sources jar into the published artifact.
Changelog
[Android] [Fixed] - Add missing sources jar into published android artifacts
Test Plan
make sure sources jar is included in artifact.