Added Support for Entrance/exit from collection by Flatlist #31630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o accessibility/flatlist-announcement
facebook-github-bot
added
the
CLA Signed
anaskhraza
changed the title
Base commit: 52a9fed |
|
Thank you @anaskhraza for this Pull Request! I've gotten you on the Improved React Native Accessibility board and added a reviewer. |
blavalla
suggested changes
Jun 7, 2021
| @@ -135,6 +136,8 @@ public static String getValue(AccessibilityRole role) { | |||
| return "android.widget.SpinButton"; | |||
| case SWITCH: | |||
| return "android.widget.Switch"; | |||
| case LIST: | |||
| return "android.widget.ListView"; | |||
There was a problem hiding this comment.
You'll want to make this "android.widget.AbsListView.class" to match Talkback's internal implementation here:
Base commit: 52a9fed |
blavalla
approved these changes
Jun 21, 2021
|
@blavalla has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This was referenced Jan 19, 2022
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #30964 .When using a screen reader, flatlist does not announce entrance/ exit from the flat list.
Changelog
[Android] [Changed] - Added support for accessibility role of "list" for flatlist and sectioned list
Test Plan
I have added accessibility role prop in flatlist and sectioned list in rntester app, that will announce entrance/ exit from flatlist and sectioned list.