[Android] Enable isInvertColorsEnabled property to AccessibilityInfo component #31070

MSzalowski · 2021-02-28T19:49:35Z

Summary

This PR enables isInvertColorsEnabled() of AccessibilityInfo for Android.

That setting is queried using the Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED property.
https://developer.android.com/reference/android/provider/Settings.Secure#ACCESSIBILITY_DISPLAY_INVERSION_ENABLED

Changelog

[Android] [Added] - isInvertColorsEnabled() of AccessibilityInfo

Test Plan

Enable and disable color inversion setting in device/emulator accessibility settings and check if property getter updates with a new value.

facebook-github-bot · 2021-02-28T19:49:38Z

Hi @MSzalowski!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

analysis-bot

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

analysis-bot · 2021-02-28T19:58:00Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

@@ -11,6 +11,7 @@
 import android.content.ContentResolver;
 import android.content.Context;
 import android.database.ContentObserver;
+import android.provider.Settings.Secure;


google-java-format suggested changes:

@@ -14 +13,0 @@ -import android.provider.Settings.Secure;

analysis-bot · 2021-02-28T19:58:00Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

@@ -95,6 +99,14 @@ private boolean getIsReduceMotionEnabledValue() {
    return value != null && value.equals("0.0");
  }

+  @TargetApi(Build.VERSION_CODES.LOLLIPOP)


google-java-format suggested changes:

@@ -105 +104,2 @@ - Settings.Secure.getString(mContentResolver, Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED); + Settings.Secure.getString( + mContentResolver, Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED);

analysis-bot · 2021-02-28T19:58:00Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

+    boolean isInvertColorsEnabled = this.getIsInvertColorsEnabled();
+
+    if (mInvertColorsEnabled != isInvertColorsEnabled) {
+      mInvertColorsEnabled = isInvertColorsEnabled;


google-java-format suggested changes:

@@ -162,2 +162,2 @@ - .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class) - .emit(INVERT_COLORS_EVENT_NAME, mInvertColorsEnabled); + .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class) + .emit(INVERT_COLORS_EVENT_NAME, mInvertColorsEnabled);

analysis-bot · 2021-02-28T19:58:00Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

+      ReactApplicationContext reactApplicationContext = getReactApplicationContextIfActiveOrWarn();
+      if (reactApplicationContext != null) {
+        reactApplicationContext
+          .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)


google-java-format suggested changes:

@@ -167 +166,0 @@ -

analysis-bot · 2021-02-28T20:12:59Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 866bf5f

facebook-github-bot · 2021-02-28T20:18:23Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

analysis-bot · 2021-02-28T20:20:54Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,903,532	-370,759
android	hermes	armeabi-v7a	8,395,536	-395,369
android	hermes	x86	9,392,110	-343,373
android	hermes	x86_64	9,334,535	-367,154
android	jsc	arm64-v8a	10,354,247	-527,640
android	jsc	armeabi-v7a	9,829,344	-562,183
android	jsc	x86	10,404,324	-505,478
android	jsc	x86_64	10,987,010	-530,904

Base commit: 118489f

analysis-bot

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

analysis-bot · 2021-03-01T11:18:59Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

@@ -95,6 +98,14 @@ private boolean getIsReduceMotionEnabledValue() {
    return value != null && value.equals("0.0");
  }

+  @TargetApi(Build.VERSION_CODES.LOLLIPOP)


google-java-format suggested changes:

@@ -103,2 +103,3 @@ - String value = Settings.Secure.getString( - mContentResolver, Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED); + String value = + Settings.Secure.getString( + mContentResolver, Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED);

analysis-bot · 2021-03-01T11:18:59Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

+
+    if (mInvertColorsEnabled != isInvertColorsEnabled) {
+      mInvertColorsEnabled = isInvertColorsEnabled;
+


google-java-format suggested changes:

@@ -161,2 +162,2 @@ - .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class) - .emit(INVERT_COLORS_EVENT_NAME, mInvertColorsEnabled); + .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class) + .emit(INVERT_COLORS_EVENT_NAME, mInvertColorsEnabled);

kacieb · 2021-03-16T20:04:21Z

Hey! Thanks so much for working on this, this is great! I'm going to tag in @blavalla to check the Android code.

Please also fix the lint related changes when you can, since we'll need those fixed to merge!

blavalla

The Android code looks good to me. Just be sure to follow the spacing that the bot suggested to keep things consistent.

analysis-bot

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

analysis-bot · 2021-03-22T18:09:56Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

@@ -95,6 +98,15 @@ private boolean getIsReduceMotionEnabledValue() {
    return value != null && value.equals("0.0");
  }

+  @TargetApi(Build.VERSION_CODES.LOLLIPOP)


google-java-format suggested changes:

@@ -103 +103 @@ - String value = + String value =

facebook-github-bot · 2021-03-29T21:42:59Z

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

blavalla

Sorry for the delay here, I didn't realize there was a gap here at first!

Let me know if you have any questions for how to implement this. The approach taken by reduce motion should be exactly what you need to follow here.

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

MSzalowski · 2021-05-22T12:42:24Z

Sorry, for the really late update. I don't want to make excuses, but I've had a really busy last few months and haven't had a moment to look here.

@blavalla
I have made the suggested changes. Could you take a look to see if it is ok now?

blavalla · 2021-05-24T19:06:18Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

@@ -58,6 +58,7 @@ public void onChange(boolean selfChange) {
        public void onChange(boolean selfChange, Uri uri) {
          if (getReactApplicationContext().hasActiveCatalystInstance()) {
            AccessibilityInfoModule.this.updateAndSendReduceMotionChangeEvent();
+            AccessibilityInfoModule.this.updateAndSendInvertColorsChangeEvent();


This isn't going to work as part of the same observer.

The way these observers work is that the URI passed into them is a reference to the specific setting changed, and this one is being trigged on Settings.Global.getUriFor(Settings.Global.TRANSITION_ANIMATION_SCALE); (line 175 of this file), which is the URI for the animation_scale setting, not the display inversion setting.

You'll instead either need to make a second ContentObserver, or use the same observer as you have done, but add a check for the URI in the onChange method and only fire the update method associated with the URI that has triggered it. Whichever approach you opt for you'll also still need to call registerContentObserver with your new URI on line 176 like this:

mContentResolver.registerContentObserver(Settings.Secure.getUriFor(Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED), false, YOUR_CONTENT_RESOLVER_HERE);

Let me know if any of this needs any clarification!

blavalla · 2021-05-24T19:07:17Z

Sorry, for the really late update. I don't want to make excuses, but I've had a really busy last few months and haven't had a moment to look here.

@blavalla
I have made the suggested changes. Could you take a look to see if it is ok now?

No problem on the timing, whenever you have time to work on this, it's appreciated!

I've commented with one change above. Let me know if anything needs any clarification!

MSzalowski · 2021-05-25T07:34:14Z

Everything is clear. Thank you for the detailed information. I'll work on this today

analysis-bot

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

analysis-bot · 2021-05-26T21:12:36Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

+      }
+    }
+  }
+
  @Override
  @TargetApi(Build.VERSION_CODES.LOLLIPOP)
  public void onHostResume() {
    mAccessibilityManager.addTouchExplorationStateChangeListener(


google-java-format suggested changes:

@@ -191 +191,2 @@ - Uri invertColorsUri = Settings.Secure.getUriFor(Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED); + Uri invertColorsUri = + Settings.Secure.getUriFor(Settings.Secure.ACCESSIBILITY_DISPLAY_INVERSION_ENABLED);

analysis-bot · 2021-05-26T21:12:37Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

+      }
+    }
+  }
+
  @Override
  @TargetApi(Build.VERSION_CODES.LOLLIPOP)
  public void onHostResume() {
    mAccessibilityManager.addTouchExplorationStateChangeListener(
        mTouchExplorationStateChangeListener);



google-java-format suggested changes:

@@ -193 +194,2 @@ - mContentResolver.registerContentObserver(invertColorsUri, false, accessibilityDisplayInversionObserver); + mContentResolver.registerContentObserver( + invertColorsUri, false, accessibilityDisplayInversionObserver);

blavalla

Thanks for the fixes, this looks great!

facebook-github-bot · 2021-06-03T19:07:05Z

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

XantreDev · 2022-12-24T10:13:05Z

What about this PR. It's seems to be approved but for some reason not merged
@kacieb Can it be approved?
Or there should be some fixes? If so I can help with it)

MSzalowski · 2022-12-28T07:07:31Z

After years - I've run google java format on requested files 😅

github-actions · 2022-12-28T07:07:33Z

	Fails
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L13 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 13 – Use relative paths when importing within 'react-native' (lint/no-react-native-imports)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L49 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 49 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L56 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 56 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L60 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 60 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L70 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 70 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L83 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 83 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L87 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 87 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L110 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 110 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L144 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 144 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L163 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 163 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L170 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 170 – Insert `·` (prettier/prettier)
🚫	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L183 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 183 – Insert `·` (prettier/prettier)

	Warnings
⚠️	Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js#L11 - Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js line 11 – Requires should be sorted alphabetically (lint/sort-imports)
⚠️	Libraries/Components/AccessibilityInfo/NativeAccessibilityInfo.js#L11 - Libraries/Components/AccessibilityInfo/NativeAccessibilityInfo.js line 11 – Requires should be sorted alphabetically (lint/sort-imports)

Generated by 🚫 dangerJS against 3d0342f

pull-bot · 2022-12-28T07:15:16Z

	Fails
🚫	❗ Base Branch - The base branch for this PR is something other than `master`. Are you sure you want to target something other than the `master` branch?

Generated by 🚫 dangerJS against 3d0342f

MSzalowski · 2022-12-28T07:59:28Z

Due to the conflicts and number of version that were released since I've sent my pr for the first time - I've closed the pr and I'll submit a new one from more recent main

analysis-bot suggested changes Feb 28, 2021

View reviewed changes

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2021

MSzalowski force-pushed the master branch from a9839be to f36257f Compare March 1, 2021 11:10

analysis-bot suggested changes Mar 1, 2021

View reviewed changes

amarlette added the Accessibility label Mar 15, 2021

amarlette requested a review from kacieb March 15, 2021 23:13

amarlette linked an issue Mar 15, 2021 that may be closed by this pull request

Android: Position in Collection not supported by Flatlist, SectionList, VirtualizedList, or ScrollView #30977

Closed

4 tasks

amarlette removed a link to an issue Mar 15, 2021

Android: Position in Collection not supported by Flatlist, SectionList, VirtualizedList, or ScrollView #30977

Closed

4 tasks

amarlette linked an issue Mar 15, 2021 that may be closed by this pull request

Android: Color inversion #30870

Open

kacieb requested a review from blavalla March 16, 2021 20:04

blavalla approved these changes Mar 16, 2021

View reviewed changes

MSzalowski force-pushed the master branch from f36257f to c889935 Compare March 22, 2021 18:00

analysis-bot suggested changes Mar 22, 2021

View reviewed changes

MSzalowski force-pushed the master branch from c889935 to 37c44ce Compare March 22, 2021 18:26

kacieb self-assigned this Mar 29, 2021

blavalla suggested changes Mar 30, 2021

View reviewed changes

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java Show resolved Hide resolved

MSzalowski force-pushed the master branch from 37c44ce to 5d65455 Compare May 22, 2021 12:38

MSzalowski requested a review from blavalla May 22, 2021 12:38

blavalla suggested changes May 24, 2021

View reviewed changes

MSzalowski force-pushed the master branch from 5d65455 to 46e8a13 Compare May 26, 2021 21:03

analysis-bot suggested changes May 26, 2021

View reviewed changes

blavalla approved these changes Jun 1, 2021

View reviewed changes

react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Oct 1, 2021

[Android] Add isInvertColorsEnabled accessibility info

3d0342f

MSzalowski force-pushed the master branch from 46e8a13 to 3d0342f Compare December 28, 2022 07:06

MSzalowski requested review from analysis-bot and removed request for kacieb December 28, 2022 07:06

MSzalowski closed this Dec 28, 2022

MSzalowski deleted the master branch December 28, 2022 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Enable isInvertColorsEnabled property to AccessibilityInfo component #31070

[Android] Enable isInvertColorsEnabled property to AccessibilityInfo component #31070

MSzalowski commented Feb 28, 2021

facebook-github-bot commented Feb 28, 2021

analysis-bot left a comment

analysis-bot Feb 28, 2021

analysis-bot Feb 28, 2021

analysis-bot Feb 28, 2021

analysis-bot Feb 28, 2021

analysis-bot commented Feb 28, 2021 •

edited

Loading

facebook-github-bot commented Feb 28, 2021

analysis-bot commented Feb 28, 2021 •

edited

Loading

analysis-bot left a comment

analysis-bot Mar 1, 2021

analysis-bot Mar 1, 2021

kacieb commented Mar 16, 2021

blavalla left a comment

analysis-bot left a comment

analysis-bot Mar 22, 2021

facebook-github-bot commented Mar 29, 2021

blavalla left a comment

MSzalowski commented May 22, 2021

blavalla May 24, 2021

blavalla commented May 24, 2021

MSzalowski commented May 25, 2021

analysis-bot left a comment

analysis-bot May 26, 2021

analysis-bot May 26, 2021

blavalla left a comment

facebook-github-bot commented Jun 3, 2021

XantreDev commented Dec 24, 2022

MSzalowski commented Dec 28, 2022

github-actions bot commented Dec 28, 2022

pull-bot commented Dec 28, 2022

MSzalowski commented Dec 28, 2022


		if (mInvertColorsEnabled != isInvertColorsEnabled) {
		mInvertColorsEnabled = isInvertColorsEnabled;

[Android] Enable isInvertColorsEnabled property to AccessibilityInfo component #31070

[Android] Enable isInvertColorsEnabled property to AccessibilityInfo component #31070

Conversation

MSzalowski commented Feb 28, 2021

Summary

Changelog

Test Plan

facebook-github-bot commented Feb 28, 2021

Action Required

Process

analysis-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

analysis-bot commented Feb 28, 2021 • edited Loading

facebook-github-bot commented Feb 28, 2021

analysis-bot commented Feb 28, 2021 • edited Loading

analysis-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kacieb commented Mar 16, 2021

blavalla left a comment

Choose a reason for hiding this comment

analysis-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Mar 29, 2021

blavalla left a comment

Choose a reason for hiding this comment

MSzalowski commented May 22, 2021

Choose a reason for hiding this comment

blavalla commented May 24, 2021

MSzalowski commented May 25, 2021

analysis-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blavalla left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Jun 3, 2021

XantreDev commented Dec 24, 2022

MSzalowski commented Dec 28, 2022

github-actions bot commented Dec 28, 2022

pull-bot commented Dec 28, 2022

MSzalowski commented Dec 28, 2022

analysis-bot commented Feb 28, 2021 •

edited

Loading

analysis-bot commented Feb 28, 2021 •

edited

Loading