Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed undefined symbols for extensions in UIKit #30202

Closed

Conversation

gabrielbull
Copy link
Contributor

Summary

I have an error when trying to build a library using Swift and UIKit:

Showing Recent Messages
Undefined symbol: (extension in UIKit):__C.UIAction.init(title: Swift.String, image: __C.UIImage?, identifier: __C.UIActionIdentifier?, discoverabilityTitle: Swift.String?, attributes: __C.UIMenuElementAttributes, state: __C.UIMenuElementState, handler: (__C.UIAction) -> ()) -> __C.UIAction
Undefined symbols for architecture x86_64:
  "(extension in UIKit):__C.UIAction.init(title: Swift.String, image: __C.UIImage?, identifier: __C.UIActionIdentifier?, discoverabilityTitle: Swift.String?, attributes: __C.UIMenuElementAttributes, state: __C.UIMenuElementState, handler: (__C.UIAction) -> ()) -> __C.UIAction", referenced from:
      static Project.RNRNavigationAction.getAction() -> () in Test.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Changelog

[iOS] [Fixed] - Fixed undefined symbols for extensions in UIKit

Test Plan

It now works.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2020
@gabrielbull
Copy link
Contributor Author

gabrielbull commented Oct 17, 2020

@priteshrnandgaonkar @rickhanlonii

Hey guys, I know you guys worked on this (cb80e3b). I am unable to build a Swift library that uses UIMenu or UIAction because of the line I removed in this PR.

Capture d’écran, le 2020-10-17 à 11 55 06

@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Oct 17, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,389,897 0
android hermes armeabi-v7a 7,017,213 0
android hermes x86 7,832,109 0
android hermes x86_64 7,721,595 0
android jsc arm64-v8a 9,536,198 0
android jsc armeabi-v7a 9,151,226 0
android jsc x86 9,400,874 0
android jsc x86_64 9,982,584 0

Base commit: 7609883

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7609883

@rickhanlonii
Copy link
Member

I'm not sure, if I worked on this it was just to land it.

cc @priteshrnandgaonkar

@gabrielbull
Copy link
Contributor Author

@priteshrnandgaonkar building fails with my changes without a Swift bridging file and fails without my changes due to the lines I removed. Any clue why?

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 22, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants