Added examples to test tapping on overflowed Views to RNTesterApp#29393
Closed
hsource wants to merge 1 commit intofacebook:mainfrom
Closed
Added examples to test tapping on overflowed Views to RNTesterApp#29393hsource wants to merge 1 commit intofacebook:mainfrom
hsource wants to merge 1 commit intofacebook:mainfrom
Conversation
Base commit: 9f699ae |
Base commit: 9f699ae |
Contributor
|
@shergin does this work on Fabric? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
By default, Views in React Native have overflow: visible. When a child view is outside of the parent view's boundaries, it's visible on Android, but not tappable. This behaviour is incorrect, and doesn't match iOS behaviour.
#26374 and #29039 both fix this. @shergin suggested:
This change does that.
Changelog
[Internal] [Added] - Added examples to test tapping on overflowed Views to RNTesterApp
Test Plan
Added tests to RNTesterApp. Here are the current results of testing on Android: