Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flipper version from 0.33.1 to 0.37.0 #28597

Closed
wants to merge 1 commit into from

Conversation

jeswinsimon
Copy link
Contributor

@jeswinsimon jeswinsimon commented Apr 11, 2020

Summary

Updating Flipper version from 0.33.1 to 0.37.0 to fix a crash in iOS when Image source is a base64 string (also reported in #28589 and #28530). This issue has been fixed in the latest build of Flipper facebook/flipper#978

Changelog

[iOS] [Changed] - Updated Flipper pod version to 0.37.0
[Android] [Changed] - Updated Flipper version to 0.37.0

Test Plan

App no longer crashes on iOS when using the below Image component

<Image style={{ width: 1, height: 1 }} source={{ uri: "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAAAAAA6fptVAAAACklEQVR4nGP6DwABBQECz6AuzQAAAABJRU5ErkJggg==" }} />

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2020
@pull-bot
Copy link

Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against e6c65bd

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Apr 11, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,607,325 0
android hermes armeabi-v7a 6,283,973 0
android hermes x86 6,948,081 0
android hermes x86_64 6,878,742 0
android jsc arm64-v8a 8,916,028 0
android jsc armeabi-v7a 8,556,018 0
android jsc x86 8,740,799 0
android jsc x86_64 9,317,726 0

Base commit: be78673

@guhungry
Copy link
Contributor

guhungry commented Apr 12, 2020

Confirmed bump flipper to 0.37.0 fix the crash

Duplicated with #28545

@jeswinsimon
Copy link
Contributor Author

jeswinsimon commented Apr 12, 2020

Closing since this is a duplicate of #28545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants