Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: Remove unused npx reference #28544

Closed
wants to merge 1 commit into from

Conversation

Esemesek
Copy link
Contributor

@Esemesek Esemesek commented Apr 6, 2020

Summary

Recently we removed npx usage from react-native-cli flow. After checking usages in this repo I found unused reference.

Changelog

[Internal] [Removed] - Remove unused npx reference

Test Plan

Tests pass

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Apr 6, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,608,583 0
android hermes armeabi-v7a 6,285,231 0
android hermes x86 6,949,332 0
android hermes x86_64 6,879,998 0
android jsc arm64-v8a 8,916,531 0
android jsc armeabi-v7a 8,556,540 0
android jsc x86 8,741,334 0
android jsc x86_64 9,318,252 0

Base commit: 4cbcee7

@analysis-bot
Copy link

analysis-bot commented Apr 6, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,977,856 0

Base commit: 4cbcee7

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Esemesek in f21b4eb.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants