[RNTester] Fix BUCK build #27826
Closed
[RNTester] Fix BUCK build #27826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was exported from Phabricator. Differential Revision: D19496769 |
passy
added a commit
to passy/react-native
that referenced
this pull request
Jan 21, 2020
Summary: This fixes a build failure with buck introduced with facebook#27729. The internal and external buck overlays diverged in how fbjni was imported. The Buck re-export here ensures that the targets resolve both internall and externally. ## Changelog [Android] [Fixed] - RNTester Buck Build Pull Request resolved: facebook#27826 Test Plan: buck fetch rntester buck build rntester Reviewed By: cpojer Differential Revision: D19496769 Pulled By: passy fbshipit-source-id: 9537c72b9d6fef14639eb7d79caec017cef2eb17
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @passy in a3cb377. When will my fix make it into a release? | Upcoming Releases |
30 tasks
rickhanlonii
pushed a commit
that referenced
this pull request
Feb 5, 2020
Summary: This fixes a build failure with buck introduced with #27729. The internal and external buck overlays diverged in how fbjni was imported. The Buck re-export here ensures that the targets resolve both internall and externally. ## Changelog [Android] [Fixed] - RNTester Buck Build Pull Request resolved: #27826 Test Plan: buck fetch rntester buck build rntester Reviewed By: jknoxville Differential Revision: D19496769 Pulled By: passy fbshipit-source-id: d699a5f64f691ed375cfc7a9d6a5a6f6e36ba283
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: This fixes a build failure with buck introduced with facebook#27729. The internal and external buck overlays diverged in how fbjni was imported. The Buck re-export here ensures that the targets resolve both internall and externally. ## Changelog [Android] [Fixed] - RNTester Buck Build Pull Request resolved: facebook#27826 Test Plan: buck fetch rntester buck build rntester Reviewed By: jknoxville Differential Revision: D19496769 Pulled By: passy fbshipit-source-id: d699a5f64f691ed375cfc7a9d6a5a6f6e36ba283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a build failure with buck introduced with #27729. The internal and external buck overlays diverged in how fbjni was imported. The Buck re-export here ensures that the targets resolve both internall and externally.
Changelog
[Android] [Fixed] - RNTester Buck Build
Test Plan
buck fetch rntester
buck build rntester
Waiting for Circle CI build to confirm.