Integrate Flipper in RNTester on Android #27631
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: Android
|
Could you rebase and take a look at the failures? |
rickhanlonii
force-pushed
the
flipper-RNTester
branch
from
4212ff9
to
aa009e7
Compare
|
I rebased onto master and tested iOS
|
|
Seems like the failing tests are failing on master as well so unrelated |
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
safaiyeh
changed the title
|
Reverted iOS changes in favor of #27762, @priteshrnandgaonkar solved the This just makes the updates to Android to be consistent with the template app |
rickhanlonii
changed the title
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @safaiyeh in 6579d8f. When will my fix make it into a release? | Upcoming Releases |
Summary: 0.62 Flipper Support items: #27565 Made RNTester's Android Flipper implementation consistent with the template. ~~Added Flipper to the iOS build.~~ <img width="1259" alt="Screen Shot 2019-12-28 at 7 06 42 PM" src="https://user-images.githubusercontent.com/8675043/71551835-37290800-29a5-11ea-9eac-b119a69a68c1.png"> ## Changelog [Internal] [Added] - RNTester Android Fipper updates Pull Request resolved: #27631 Test Plan: Run RNTester and see if it connects to Flipper. Reviewed By: rickhanlonii Differential Revision: D19345093 Pulled By: passy fbshipit-source-id: 6957c1ca3f4a5bb7f0e581c5daf8ddeac5d87eea
Summary: 0.62 Flipper Support items: facebook#27565 Made RNTester's Android Flipper implementation consistent with the template. ~~Added Flipper to the iOS build.~~ <img width="1259" alt="Screen Shot 2019-12-28 at 7 06 42 PM" src="https://user-images.githubusercontent.com/8675043/71551835-37290800-29a5-11ea-9eac-b119a69a68c1.png"> ## Changelog [Internal] [Added] - RNTester Android Fipper updates Pull Request resolved: facebook#27631 Test Plan: Run RNTester and see if it connects to Flipper. Reviewed By: rickhanlonii Differential Revision: D19345093 Pulled By: passy fbshipit-source-id: 6957c1ca3f4a5bb7f0e581c5daf8ddeac5d87eea
Summary
0.62 Flipper Support items: #27565
Made RNTester's Android Flipper implementation consistent with the template.
Added Flipper to the iOS build.Changelog
[Internal] [Added] - RNTester Android Fipper updates
Test Plan
Run RNTester and see if it connects to Flipper.