Set minimum width and height for views #25498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can help when creating custom ViewGroups
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: Android
|
@M-i-k-e-l Shouldn't we drop in from |
|
@osdnk What do you mean by "drop in from |
|
Hello @M-i-k-e-l, thank you for the contribution. Could you please provide a test plan with an example when this might be useful? As far as I can see we already have minWidth and minHeight properties supported. |
|
Frankly speaking, I don't understand this PR. Can you add some text / gifs / screenshots / snack? |
shergin
suggested changes
Jul 18, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
Summary: This sync includes the following changes: - **[54f297a60](facebook/react@54f297a60 )**: Enable useMemoCacheHook for ReactNative-fb build ([#25498](facebook/react#25498)) //<Jan Kassens>// Changelog: [General][Changed] - React Native sync for revisions 9fb581c...54f297a jest_e2e[run_all_tests] Reviewed By: poteto Differential Revision: D40435957 fbshipit-source-id: f447f50d80298e2c3e8be09ff52b1bedcfe6d402
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This sync includes the following changes: - **[54f297a60](facebook/react@54f297a60 )**: Enable useMemoCacheHook for ReactNative-fb build ([facebook#25498](facebook/react#25498)) //<Jan Kassens>// Changelog: [General][Changed] - React Native sync for revisions 9fb581c...54f297a jest_e2e[run_all_tests] Reviewed By: poteto Differential Revision: D40435957 fbshipit-source-id: f447f50d80298e2c3e8be09ff52b1bedcfe6d402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This can help when creating custom ViewGroups (in native modules).
For example: images need to have size in order to be shown, and if the minimum size (width\height) is not set their size is 0.
Changelog
[Android] [Added] - add
setMinWidthandsetMinHeighttoBaseViewManager.[CATEGORY] [TYPE] - Message
Test Plan