Skip to content

[jest] Explicitly separate mocked native modules from mocked JS modules #24809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[jest] Explicitly separate mocked native modules from mocked JS modules #24809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions Libraries/Image/__tests__/resolveAssetSource-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,19 @@

'use strict';

const AssetRegistry = require('../AssetRegistry');
const Platform = require('../../Utilities/Platform');
const resolveAssetSource = require('../resolveAssetSource');

import NativeSourceCode from '../../NativeModules/specs/NativeSourceCode';

function expectResolvesAsset(input, expectedSource) {
const assetId = AssetRegistry.registerAsset(input);
expect(resolveAssetSource(assetId)).toEqual(expectedSource);
}

describe('resolveAssetSource', () => {
let AssetRegistry;
let resolveAssetSource;
let NativeSourceCode;
let Platform;

beforeEach(() => {
jest.resetModules();

AssetRegistry = require('../AssetRegistry');
resolveAssetSource = require('../resolveAssetSource');
NativeSourceCode = require('../../NativeModules/specs/NativeSourceCode').default;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Insert ⏎······

Platform = require('../../Utilities/Platform');
});

it('returns same source for simple static and network images', () => {
Expand Down Expand Up @@ -303,9 +302,16 @@ describe('resolveAssetSource', () => {
);
});
});

function expectResolvesAsset(input, expectedSource) {
const assetId = AssetRegistry.registerAsset(input);
expect(resolveAssetSource(assetId)).toEqual(expectedSource);
}
});

describe('resolveAssetSource.pickScale', () => {
const resolveAssetSource = require('../resolveAssetSource');

it('picks matching scale', () => {
expect(resolveAssetSource.pickScale([1], 2)).toBe(1);
expect(resolveAssetSource.pickScale([1, 2, 3], 2)).toBe(2);
Expand Down
Loading