[emitter] Fix sparse array handling in EventEmitter#listeners()
#24546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Fixes a regression in facebook@1f8b46a#diff-141db70a3fb9a501015e4cb2508e3a65. The internal subscription vendor uses a sparse array to track listeners, which makes listener removal fast. When querying listeners, the sparse entries need to be removed. `Array#filter` is a built-in way to do this -> linked to the JS spec, which explains this.
cpojer
approved these changes
Apr 23, 2019
facebook-github-bot
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ide in b76acd3. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
May 6, 2019
Summary: Fixes a regression in 1f8b46a. The internal subscription vendor uses a sparse array to track listeners, which makes listener removal fast. When querying listeners, the sparse entries need to be removed. `Array#filter` is a built-in way to do this -> linked to the JS spec, which explains this. [General] [Fixed] - Fixed sparse array handling in `EventEmitter#listeners()` Pull Request resolved: #24546 Differential Revision: D15044790 Pulled By: cpojer fbshipit-source-id: 0f1301618739357b4a0f5378b9584efe74f0f09a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in 1f8b46a. The internal subscription vendor uses a sparse array to track listeners, which makes listener removal fast. When querying listeners, the sparse entries need to be removed.
Array#filteris a built-in way to do this -> linked to the JS spec, which explains this.Changelog
[General] [Fixed] - Fixed sparse array handling in
EventEmitter#listeners()Test Plan
Ran tests outside of this repo that now pass