Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run packager in Release mode #23938

Closed
wants to merge 1 commit into from
Closed

Do not run packager in Release mode #23938

wants to merge 1 commit into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Mar 14, 2019

Summary

When running your project in "Release" mode, Metro will start automatically. This is not desired. See react-native-community/cli#31 for details

Changelog

[IOS] [FIXED] - Do not start Metro in Release mode

Test Plan

Run RNTester in Release mode - packager doesn't start anymore

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2019
@grabbou
Copy link
Contributor Author

grabbou commented Mar 14, 2019

Since the diff is hard to read, I only added:

&& [ \"$CONFIGURATION\" == \"Debug\" ] ;

to the if statement.

After changes, it's:

if [ -z "${RCT_NO_LAUNCH_PACKAGER+xxx}" ] && [ "$CONFIGURATION" == "Debug" ] ; then

@react-native-bot react-native-bot added the Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used. label Mar 14, 2019
cpojer
cpojer approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg thank you, that was so annoying when I tried this the last time.

facebook-github-bot
facebook-github-bot approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @grabbou in 581711c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 15, 2019
grabbou added a commit that referenced this pull request Mar 15, 2019
@grabbou
Do not run packager in Release mode (#23938)
2b2e1d5 
Summary:
When running your project in "Release" mode, Metro will start automatically. This is not desired. See react-native-community/cli#31 for details

[IOS] [FIXED] - Do not start Metro in Release mode
Pull Request resolved: #23938

Differential Revision: D14477595

Pulled By: cpojer

fbshipit-source-id: 05166537500fa95a59ae87f27154c9665b7ccfe8
@deepsweet
Copy link

Changes from this PR are reverted back with this commit. Was it a mistake?

@grabbou
Copy link
Contributor Author

grabbou commented May 17, 2019

That looks like a mistake.

CC: @lucasbento @cpojer the diff in linked PR removes check for $CONFIGURATION being Debug

@cpojer
Copy link
Contributor

cpojer commented May 17, 2019

Oh yeah, totally missed this when reviewing. Sorry about that! @deepsweet could you send a PR to bring this back?

@lucasbento
Copy link
Contributor

I'll open a PR to fix this, sorry!

@lucasbento lucasbento mentioned this pull request May 17, 2019
Closed
@lucasbento
Copy link
Contributor

PR #24929, thanks for checking this @deepsweet!

facebook-github-bot pushed a commit that referenced this pull request May 20, 2019
@lucasbento @facebook-github-bot
Do not run packager in Release mode (#24929)
4ea6204 
Summary:
This PR fixes a regression introduced on [3273d23](3273d23#diff-883359f85083d00b7266ec2acebcca9f) that removed #23938.

It also adds the check for `React` and `React-tvOS` targets.

## Changelog

[IOS] [FIXED] - Do not run packager in Release mode
Pull Request resolved: #24929

Differential Revision: D15391692

Pulled By: cpojer

fbshipit-source-id: c2e524108be3bf1e45b0d0ff7cddd9785b51a60f
@hramos hramos deleted the fix/packager-start branch February 25, 2020 19:20
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
@lucasbento @M-i-k-e-l
Do not run packager in Release mode (facebook#24929)
a1ac31e 
Summary:
This PR fixes a regression introduced on [3273d23](facebook@3273d23#diff-883359f85083d00b7266ec2acebcca9f) that removed facebook#23938.

It also adds the check for `React` and `React-tvOS` targets.

## Changelog

[IOS] [FIXED] - Do not run packager in Release mode
Pull Request resolved: facebook#24929

Differential Revision: D15391692

Pulled By: cpojer

fbshipit-source-id: c2e524108be3bf1e45b0d0ff7cddd9785b51a60f
@niraj-khatiwada
Copy link

niraj-khatiwada commented Jun 3, 2021 •
edited
Loading

Thank god this worked. This was driving me crazy for hours. Kudos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grabbou @react-native-bot @deepsweet @cpojer @lucasbento @niraj-khatiwada @facebook-github-bot