Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to official node image in ci #23423

Closed
wants to merge 3 commits into from

Conversation

gengjiawen
Copy link
Contributor

Summary

The official node image bundled with yarn by default, and it has maintained by the official group so we can always get the latest version.

Test Plan

pass current ci.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Partner labels Feb 13, 2019
@gengjiawen gengjiawen requested a review from cpojer February 13, 2019 12:38
@pull-bot
Copy link

pull-bot commented Feb 13, 2019

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS against 98ff88e

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 13, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@gengjiawen merged commit e6320c6 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 13, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 13, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: Image Component: Switch Contributor A React Native contributor. Merged This PR has been merged. Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants