Closed
Conversation
facebook-github-bot
added
CLA Signed
Generated by 🚫 dangerJS |
react-native-bot
added
PR: Includes Changelog
Platform: Android
mdvacca
reviewed
Feb 9, 2019
| public ReactTextInputShadowNode() { | ||
| mTextBreakStrategy = (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) ? | ||
| 0 : Layout.BREAK_STRATEGY_SIMPLE; | ||
| Layout.BREAK_STRATEGY_SIMPLE : Layout.BREAK_STRATEGY_HIGH_QUALITY; |
Contributor
There was a problem hiding this comment.
is this change of behavior correct?
Contributor
Author
There was a problem hiding this comment.
BREAK_STRATEGY_HIGH_QUALITY was introduced in 23 or M, and is a default text breaking strategy. Before that BREAK_STRATEGY_SIMPLE was default, which has value of 0.
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 10, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@dulmandakh merged commit d2fc19f into |
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix lint errors and warning, which might be a cause of various crashes on older Android OS, using Android Support Library.
Changelog
[Android] [Changed] - fix lint error/warnings
Test Plan
CI is green