Map TextInput textContentType strings to Objective-C constants #22611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Thanks for the build output logs @TheSavior -- I've updated the code and tested on an older versions of Xcode so this should work now. @shergin would I be able to get a quick re-review? |
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
4 times, most recently
from
f174de3
to
bd78d35
Compare
There was a problem hiding this comment.
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
chuganzy
reviewed
Dec 19, 2018
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
2 times, most recently
from
4118d50
to
303aa76
Compare
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
from
303aa76
to
0ed4ece
Compare
3 tasks
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
from
0ed4ece
to
58b0f91
Compare
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
from
58b0f91
to
ce41dd1
Compare
|
Label should be updated to |
|
@levibuzolic - Any word on what version this PR might make it into? |
|
@mcgaryes unfortunately not. It’s with the RN team now. It’s ready to merge but has been sitting here for a while without any attention. 🤷♂️ |
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
from
ce41dd1
to
8adacab
Compare
levibuzolic
changed the title
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
from
8adacab
to
2f4f2d4
Compare
levibuzolic
force-pushed
the
map-textcontenttype-to-constants-compile-fix
branch
from
2f4f2d4
to
6223c73
Compare
|
@shergin anything I can do to get this across the line for a future release? Should be good to go as far as I can tell. |
3 tasks
|
@kelset sorry to ping you here, but I'm really keen to try and get this in to the next release, any chance I could get a review/merge from the team? |
|
Hey thanks for the ping - I'll see if we can merge it but no promises 😛 |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@levibuzolic merged commit a89fe41 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
…ook#22611) Summary: This is an updated version of facebook#22579 which uses compile conditionals to prevent `use of undeclared identifier` errors when compiling on older versions of Xcode. -------- Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue facebook#22578 has more detail examples/explanation. Pull Request resolved: facebook#22611 Differential Revision: D13460949 Pulled By: cpojer fbshipit-source-id: e6d1108422b850ebc3aea05693ed05118b77b5de
hramos
removed
Import Started
grabbou
pushed a commit
that referenced
this pull request
Feb 27, 2019
Summary: This is an updated version of #22579 which uses compile conditionals to prevent `use of undeclared identifier` errors when compiling on older versions of Xcode. -------- Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation. Pull Request resolved: #22611 Differential Revision: D13460949 Pulled By: cpojer fbshipit-source-id: e6d1108422b850ebc3aea05693ed05118b77b5de
grabbou
pushed a commit
that referenced
this pull request
Feb 28, 2019
Summary: This is an updated version of #22579 which uses compile conditionals to prevent `use of undeclared identifier` errors when compiling on older versions of Xcode. -------- Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation. Pull Request resolved: #22611 Differential Revision: D13460949 Pulled By: cpojer fbshipit-source-id: e6d1108422b850ebc3aea05693ed05118b77b5de
buoyad
pushed a commit
to keybase/react-native
that referenced
this pull request
Apr 22, 2019
…ook#22611) Summary: This is an updated version of facebook#22579 which uses compile conditionals to prevent `use of undeclared identifier` errors when compiling on older versions of Xcode. -------- Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue facebook#22578 has more detail examples/explanation. Pull Request resolved: facebook#22611 Differential Revision: D13460949 Pulled By: cpojer fbshipit-source-id: e6d1108422b850ebc3aea05693ed05118b77b5de
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…ook#22611) Summary: This is an updated version of facebook#22579 which uses compile conditionals to prevent `use of undeclared identifier` errors when compiling on older versions of Xcode. -------- Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue facebook#22578 has more detail examples/explanation. Pull Request resolved: facebook#22611 Differential Revision: D13460949 Pulled By: cpojer fbshipit-source-id: e6d1108422b850ebc3aea05693ed05118b77b5de
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #22579 which uses compile conditionals to prevent
use of undeclared identifiererrors when compiling on older versions of Xcode.Summary
Currently the only
textContentTypevalues that work are:username,password,location,nameandnickname. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation.Test Plan
Added a Text Content Type example to the RNTester app which shows two examples which weren't previously working.
Changelog
[iOS] [Fixed] - Fixes textContentTypes not working by mapping textContentType strings to Objective-C constants - Fixes #22578