Fix build error for Android projects that use apply plugin: "com.android.library"
#22312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for the PR. This looks good to me. |
hramos
removed
Import Started
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Nov 11, 2020
…roid.library"` (facebook#22312) Summary: This PR allows Android projects that use `apply plugin: "com.android.library"` to build successfully. A recent regression caused by facebook#20526 means that building one of these projects always fails with this error: ``` FAILURE: Build failed with an exception. * Where: Script '/Users/james/src/SampleLibrary/node_modules/react-native/react.gradle' line: 15 * What went wrong: A problem occurred configuring project ':app'. > Could not get unknown property 'applicationVariants' for object of type com.android.build.gradle.LibraryExtension. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 0s ``` This change updates `react.gradle` to cater to both application and library projects by selectively using `android.applicationVariants` or `android.libraryVariants`. Fixes facebook#22310. Pull Request resolved: facebook#22312 Differential Revision: D13373742 Pulled By: cpojer fbshipit-source-id: 64c35ab7a6d5d0d840a43729123e70dd8e0d36e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Android projects that use
apply plugin: "com.android.library"to build successfully. A recent regression caused by #20526 means that building one of these projects always fails with this error:This change updates
react.gradleto cater to both application and library projects by selectively usingandroid.applicationVariantsorandroid.libraryVariants.Fixes #22310.
Test Plan:
Build any Android project with
apply plugin: "com.android.library"using./gradlew build(I have a sample project here: https://github.com/jtreanor/sample-library-react-native). It will now succeed with these changes.Changelog:
[Android] [Fixed] - Fixed build error with Android library projects