Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in README.md #20993

Closed
wants to merge 1 commit into from
Closed

fix typo in README.md #20993

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Contributor

Motivation

The original facebook is misspelled.

Test Plan

pass all current ci.

Related PRs

none

Release Notes

[GENERAL] [INTERNAL] [MISC] - fix typo in README.md

@gengjiawen gengjiawen requested a review from hramos as a code owner September 5, 2018 23:53
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2018
@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 6, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 6, 2018
facebook-github-bot
facebook-github-bot approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 6, 2018
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@gengjiawen
Copy link
Contributor Author

@hramos The import failed. Also this pr too #18754.

@hramos
Copy link
Contributor

hramos commented Sep 6, 2018

It looks like this actually landed internally, but has not synced out yet. Investigating now.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 7, 2018
@react-native-bot
Copy link
Collaborator

@gengjiawen merged commit d838b6c into facebook:master.

Once this commit is added to a release, you will see the corresponding version tag below the description at d838b6c. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 7, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 7, 2018
gengjiawen added a commit to gengjiawen/react-native that referenced this pull request Sep 14, 2018
@gengjiawen
fix typo in README.md (facebook#20993)
3e8a4ff 
Summary:
The original facebook is misspelled.
pass all current ci.
none
 [GENERAL] [INTERNAL] [MISC] - fix typo in README.md
Pull Request resolved: facebook#20993

Differential Revision: D9671977

Pulled By: hramos

fbshipit-source-id: 2c279cb681696460801e11012b4a456d5375ce24
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@gengjiawen @facebook-github-bot
fix typo in README.md (facebook#20993)
a209cdd 
Summary:
The original facebook is misspelled.
pass all current ci.
none
 [GENERAL] [INTERNAL] [MISC] - fix typo in README.md
Pull Request resolved: facebook#20993

Differential Revision: D9671977

Pulled By: hramos

fbshipit-source-id: 2c279cb681696460801e11012b4a456d5375ce24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dulmandakh dulmandakh dulmandakh approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @facebook-github-bot @hramos @react-native-bot @dulmandakh