-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve contrast ratio in debugger-ui dark mode #20559
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Generated by 🚫 dangerJS |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@lgraubner merged commit 8dc209a into Once this commit is added to a release, you will see the corresponding version tag below the description at 8dc209a. If the commit has a single |
Summary: The font colors in the debugger-ui dark mode are not accessible. This PR ensures [Level AAA Conformance to Web Content Accessibility Guidelines 2.0](https://www.w3.org/WAI/WCAG2AAA-Conformance) which makes it better to read for everyone. Pull Request resolved: facebook#20559 Differential Revision: D9495584 Pulled By: hramos fbshipit-source-id: 1a9bdd015935fb27e2d74d2399e687787282a987
Summary: The font colors in the debugger-ui dark mode are not accessible. This PR ensures [Level AAA Conformance to Web Content Accessibility Guidelines 2.0](https://www.w3.org/WAI/WCAG2AAA-Conformance) which makes it better to read for everyone. Pull Request resolved: facebook/react-native#20559 Differential Revision: D9495584 Pulled By: hramos fbshipit-source-id: 1a9bdd015935fb27e2d74d2399e687787282a987
Summary: The font colors in the debugger-ui dark mode are not accessible. This PR ensures [Level AAA Conformance to Web Content Accessibility Guidelines 2.0](https://www.w3.org/WAI/WCAG2AAA-Conformance) which makes it better to read for everyone. Pull Request resolved: facebook#20559 Differential Revision: D9495584 Pulled By: hramos fbshipit-source-id: 1a9bdd015935fb27e2d74d2399e687787282a987
The font colors in the debugger-ui dark mode are not accessible. This PR ensures Level AAA Conformance to Web Content Accessibility Guidelines 2.0 which makes it better to read for everyone.
Test Plan:
No tests needed, CSS changes only.
Release Notes:
[GENERAL][ENHANCEMENT][./local-cli/server/util/debugger-ui/index.html] improve contrast ratio in debugger-ui dark mode