Added necessary headers and sources to fix compilation errors for tvOS target#20406
Closed
onurersel wants to merge 1 commit intofacebook:masterfrom
Closed
Added necessary headers and sources to fix compilation errors for tvOS target#20406onurersel wants to merge 1 commit intofacebook:masterfrom
onurersel wants to merge 1 commit intofacebook:masterfrom
Conversation
…ors for tvOS target.
react-native-bot
added
🐛Bug Fix
Platform: iOS
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jul 30, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was closed by Onur Ersel in 1f1ddd0. Once this commit is added to a release, you will see the corresponding version tag below the description at 1f1ddd0. If the commit has a single |
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With version 0.56.0, XCode doesn't compile and run the scheme for tvOS. This commit adds missing headers and sources to build phases in React project.
Fixes #20087
Test Plan:
Building
React-tvOSscheme in projectReact/React.xcodeprojwas failing with errors.It should compile successfully with this commit.
Release Notes:
[IOS] [BUGFIX] [React/React.xcodeproj] - Added necessary headers and sources to fix compilation errors for tvOS target