Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RNTester on Windows #19974

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert remove type to stay this pr clean.
  • Loading branch information
gengjiawen committed Aug 3, 2018
commit b69a1549802daddc4dc69f548bffa54c3ab40b91
2 changes: 1 addition & 1 deletion local-cli/bundle/bundleCommandLineArgs.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ module.exports = [
'Specifies the maximum number of workers the worker-pool ' +
'will spawn for transforming files. This defaults to the number of the ' +
'cores available on your machine.',
parse: (workers) => Number(workers),
parse: (workers: string) => Number(workers),
},
{
command: '--sourcemap-output [string]',
Expand Down
2 changes: 1 addition & 1 deletion local-cli/dependencies/dependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module.exports = {
'Specifies the maximum number of workers the worker-pool ' +
'will spawn for transforming files. This defaults to the number of the ' +
'cores available on your machine.',
parse: (workers) => Number(workers),
parse: (workers: string) => Number(workers),
},
{
command: '--dev [boolean]',
Expand Down
2 changes: 1 addition & 1 deletion local-cli/runAndroid/runAndroid.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ module.exports = {
{
command: '--port [number]',
default: process.env.RCT_METRO_PORT || 8081,
parse: (val) => Number(val),
parse: (val: string) => Number(val),
},
],
};
2 changes: 1 addition & 1 deletion local-cli/runIOS/runIOS.js
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ module.exports = {
{
command: '--port [number]',
default: process.env.RCT_METRO_PORT || 8081,
parse: (val) => Number(val),
parse: (val: string) => Number(val),
},
],
};