-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump NDK toolchain to 4.9 #19945
bump NDK toolchain to 4.9 #19945
Conversation
Also cc @fkgozali |
@fkgozali please review and merge |
Or maybe #19893, which does the same but also bumps NDK version. I tried every NDK version, and r14b was the latest version to compile with minimal code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@hramos is there any issue regarding merging this PR? I was able to compile RN with latest NDK, and would like to create a PR once this merged. |
@dulmandakh No, no issues. We try to avoid landing diffs late on Friday afternoons. I'll get this going today. |
This pull request was closed by @dulmandakh in ccdd450. Once this commit is added to a release, you will see the corresponding version tag below the description at ccdd450. If the commit has a single |
This PR will bump NDK_TOOLCHAIN_VERSION to 4.9 or use GCC 4.9 to build C++ code. Once merged, we can bump folly to a newer version, which requires GCC 4.9.
Test Plan:
Everything build and run as usual.
Release Notes:
[ANDROID] [ENHANCEMENT] [NDK] - bump NDK_TOOLCHAIN_VERSION to 4.9