[ListView] Operate on the true scroll responder instead of the scroll component #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sahrens, this is the crash and corresponding PR I mentioned on your sync commit. |
… component When composing scroll views, `this.refs[SCROLLVIEW_REF]` may refer to another higher-order scroll component instead of a ScrollView. This can cause issues if you expect to need it to be a ScrollView backed by an RCTScrollView. The solution is to call `getScrollResponder()` - as long as all higher-order scroll components implement this method, it will make its way down to the true ScrollView, which is what ListView wants here. Test Plan: Load an app with composed scroll views and no longer get a crash in `calculateChildFrames:(NSNumber *)reactTag callback:(RCTResponseSenderBlock)callback`.
ide
force-pushed
the
fix-scroll-responder-ref
branch
from
f7681a0 to
e9a31fa
Compare
facebook-github-bot
added
the
CLA Signed
|
Cool - I have another bug fix that will conflict with this, but shouldn't be an issue to stack them. |
ide
added a commit
that referenced
this pull request
Jul 16, 2015
… component Summary: When composing scroll views, `this.refs[SCROLLVIEW_REF]` may refer to another higher-order scroll component instead of a ScrollView. This can cause issues if you expect to need it to be a ScrollView backed by an RCTScrollView. The solution is to call `getScrollResponder()` - as long as all higher-order scroll components implement this method, it will make its way down to the true ScrollView, which is what ListView wants here. Closes #1927 Github Author: James Ide <ide@jameside.com>
Fanghao
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 22, 2015
… component Summary: When composing scroll views, `this.refs[SCROLLVIEW_REF]` may refer to another higher-order scroll component instead of a ScrollView. This can cause issues if you expect to need it to be a ScrollView backed by an RCTScrollView. The solution is to call `getScrollResponder()` - as long as all higher-order scroll components implement this method, it will make its way down to the true ScrollView, which is what ListView wants here. Closes facebook#1927 Github Author: James Ide <ide@jameside.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When composing scroll views,
this.refs[SCROLLVIEW_REF]may refer to another higher-order scroll component instead of a ScrollView. This can cause issues if you expect to need it to be a ScrollView backed by an RCTScrollView.The solution is to call
getScrollResponder()- as long as all higher-order scroll components implement this method, it will make its way down to the true ScrollView, which is what ListView wants here.Test Plan: Load an app with composed scroll views and no longer get a crash in
calculateChildFrames:(NSNumber *)reactTag callback:(RCTResponseSenderBlock)callback.