-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add platform hook for View style props #18100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You asked elsewhere how this might impact the docs. Right now, |
Similar to the `ViewPropTypes` hook to allow customization of prop types for iOS and Android, it's also useful to allow platforms to override style prop types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
It looks like with this change, some of our own internal apps are failing to build. I'll need to add this to my queue of diffs that need to be manually landed. |
@hramos - any luck? |
I haven't gotten around to it yet. Some of our apps are failing to build with this error:
|
@hramos - I imagine this may be because the |
@hramos - perhaps we just leave
|
We are currently working on getting rid of PropTypes altogether and using Flow Types to describe View props. I'm gonna close this PR and I'm sorry we didn't get to it earlier. |
Similar to the
ViewPropTypes
hook to allow customization of prop types for iOS and Android, it's also useful to allow platforms to override style prop types.Motivation
(Write your motivation here.)
Test Plan
Run jest tests.
Related PRs
#15175
Release Notes
[GENERAL][ENHANCEMENT][MINOR][View] - Add platform hook for adding View style props