iOS: Fix Crash when CameraRoll is getting assets from iCloud and no filename is provided. #13671 #17549
Conversation
…loud, no filename comes with them and the application crashes
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -199,7 +199,7 @@ static void RCTResolvePromise(RCTPromiseResolveBlock resolve, | |||
| @"group_name": [group valueForProperty:ALAssetsGroupPropertyName], | |||
| @"image": @{ | |||
| @"uri": uri, | |||
| @"filename" : filename, | |||
| @"filename" : filename ? filename : @"", | |||
There was a problem hiding this comment.
filename ?: [NSNull null] might be better
|
Thanks for the update. This looks good to me. @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ilename is provided. #13671 Summary: RCTCameraRollManager.m crashes when there is no filename provided for the asset (usually from iCloud). #13671 Tested on real device with iCloud library using the library without and after my fix. It worked after my changes. [IOS] [BUGFIX] [CameraRoll] - Changed the filename if nil to be empty when the asset is coming from iCloud. Closes facebook/react-native#17549 Differential Revision: D6710665 Pulled By: hramos fbshipit-source-id: 319865b0a71728798c62ee380e7bee4af584b3e3
Motivation
RCTCameraRollManager.m crashes when there is no filename provided for the asset (usually from iCloud). #13671
Test Plan
Tested on real device with iCloud library using the library without and after my fix. It worked after my changes.
Release Notes
[IOS] [BUGFIX] [CameraRoll] - Changed the filename if nil to be empty when the asset is coming from iCloud.