Disable git hooks for the upgrade process #16855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Looks good to me 👍 Nothing should restrict the upgrade process once the command starts. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 16, 2017
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
Summary: I'm loving `react-native-git-upgrade`, such a life and time saver, but when doing the upgrade, if git hooks are defined globally to be applied, `react-native-git-upgrade` uses these git hooks, although they might not be relevant to the upgrade process (and potentially make it way longer). Btw, thanks ncuillery for the great tool 😄 To test, I : * cloned my project * upgraded it with the npm published `react-native-git-upgrade` version : Git hooks are running during the upgrade * cloned the `react-native` repo * did my modifications on the `react-native-git-upgrade/cliEntry.js` file * `npm i -g react-native-git-upgrade/` after running `yarn` in that folder * Re-cloned my project in another folder * Upgraded it with `react-native-git-upgrade` : The hooks are not running anymore, yay! [CLI] [ENHANCEMENT] [react-native/react-native-git-upgrade] - Do not run git hooks in the upgrade process I plan to add an option to the cli so you can pass `--verify` or `--use-git-hooks` if you DO want your git hooks to run, but don't have the time right now and I think the default should be to not run them. Closes facebook#16855 Differential Revision: D6353781 Pulled By: hramos fbshipit-source-id: e4b0f55d10c37bc805b32cb4c0fe3c863346482d
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: I'm loving `react-native-git-upgrade`, such a life and time saver, but when doing the upgrade, if git hooks are defined globally to be applied, `react-native-git-upgrade` uses these git hooks, although they might not be relevant to the upgrade process (and potentially make it way longer). Btw, thanks ncuillery for the great tool 😄 To test, I : * cloned my project * upgraded it with the npm published `react-native-git-upgrade` version : Git hooks are running during the upgrade * cloned the `react-native` repo * did my modifications on the `react-native-git-upgrade/cliEntry.js` file * `npm i -g react-native-git-upgrade/` after running `yarn` in that folder * Re-cloned my project in another folder * Upgraded it with `react-native-git-upgrade` : The hooks are not running anymore, yay! [CLI] [ENHANCEMENT] [react-native/react-native-git-upgrade] - Do not run git hooks in the upgrade process I plan to add an option to the cli so you can pass `--verify` or `--use-git-hooks` if you DO want your git hooks to run, but don't have the time right now and I think the default should be to not run them. Closes facebook#16855 Differential Revision: D6353781 Pulled By: hramos fbshipit-source-id: e4b0f55d10c37bc805b32cb4c0fe3c863346482d
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: I'm loving `react-native-git-upgrade`, such a life and time saver, but when doing the upgrade, if git hooks are defined globally to be applied, `react-native-git-upgrade` uses these git hooks, although they might not be relevant to the upgrade process (and potentially make it way longer). Btw, thanks ncuillery for the great tool 😄 To test, I : * cloned my project * upgraded it with the npm published `react-native-git-upgrade` version : Git hooks are running during the upgrade * cloned the `react-native` repo * did my modifications on the `react-native-git-upgrade/cliEntry.js` file * `npm i -g react-native-git-upgrade/` after running `yarn` in that folder * Re-cloned my project in another folder * Upgraded it with `react-native-git-upgrade` : The hooks are not running anymore, yay! [CLI] [ENHANCEMENT] [react-native/react-native-git-upgrade] - Do not run git hooks in the upgrade process I plan to add an option to the cli so you can pass `--verify` or `--use-git-hooks` if you DO want your git hooks to run, but don't have the time right now and I think the default should be to not run them. Closes facebook#16855 Differential Revision: D6353781 Pulled By: hramos fbshipit-source-id: e4b0f55d10c37bc805b32cb4c0fe3c863346482d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm loving
react-native-git-upgrade, such a life and time saver, but when doing the upgrade, if git hooks are defined globally to be applied,react-native-git-upgradeuses these git hooks, although they might not be relevant to the upgrade process (and potentially make it way longer).Btw, thanks @ncuillery for the great tool 😄
Test Plan
To test, I :
react-native-git-upgradeversion : Git hooks are running during the upgradereact-nativereporeact-native-git-upgrade/cliEntry.jsfilenpm i -g react-native-git-upgrade/after runningyarnin that folderreact-native-git-upgrade: The hooks are not running anymore, yay!Release Notes
[CLI] [ENHANCEMENT] [react-native/react-native-git-upgrade] - Do not run git hooks in the upgrade process
Notes
I plan to add an option to the cli so you can pass
--verifyor--use-git-hooksif you DO want your git hooks to run, but don't have the time right now and I think the default should be to not run them.