Adds hook for platform-specific View props #15175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platforms that plug in to react-native may require additional props that are specific to those platforms. For example, already in react-native there are props that are specific to Android (`accessibilityComponentType`, `needsOffscreenAlphaCompositing`, etc.), props that are specific to iOS (`accessibilityTraits`, `shouldRasterizeIOS`, etc.) and props that are specific to tvOS (`isTVSelectable`, `tvParallaxProperties`, etc.). I need to add properties to `react-native-windows`, and I'd prefer not to override the entire `ViewPropTypes` file as it is a risk that things in react-native-windows fall out of sync with react-native. Fixes #15173
facebook-github-bot
added
CLA Signed
eslint-bot
reviewed
Jul 24, 2017
| * @flow | ||
| */ | ||
|
|
||
| module.export = {} |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 25, 2017
Summary: The following PR modifies the Danger rules in the following way: 1. Verifies if a PR is opened against master. If not, it will warn (if opened against stable) or fail (anything else). 2. No longer adds a markdown message tagging the facebook/react-native team, as the bot does not have the necessary scope to mention the team. 3. Mentions people that have marked themselves as interested in a file, when that file is modified. This is based off CODEOWNERS. The bot should be able to use mentions here as it will act as any other regular user. Verify it tags the right people in #15139 ``` $ npm run danger pr #15139 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "#15139" { fails: [], warnings: [], messages: [], markdowns: ["Attention: grabbou, kureev"] } ``` It should not tag anyone for #15175: ``` $ npm run danger pr #15175 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "#15175" { fails: [], warnings: [], messages: [], markdowns: [] } ``` It should warn on #14640 as it targets 0.45-stable: ``` $ npm run danger pr #14640 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "#14640" { fails: [], warnings: [ { message: ":grey_question: Base Branch - <i>The base branch for this PR is something other than `master`. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on `master` first and then cherry-pick the commits into the branch for that release. The [Releases Guide](https://github.com/facebook/react-native/blob/master/Releases.md) has more information.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` It should not warn on #15175 because it targets master. ``` $ npm run danger pr #15175 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "#15175" { fails: [], warnings: [], messages: [], markdowns: [] } ``` Closes #15179 Differential Revision: D5490047 Pulled By: hramos fbshipit-source-id: a46a23b7d0a59d12b8039746d6e9c4399ef32d5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms that plug in to react-native may require additional props that are specific to those platforms. For example, already in react-native there are props that are specific to Android (
accessibilityComponentType,needsOffscreenAlphaCompositing, etc.), props that are specific to iOS (accessibilityTraits,shouldRasterizeIOS, etc.) and props that are specific to tvOS (isTVSelectable,tvParallaxProperties, etc.).I need to add properties to
react-native-windows, and I'd prefer not to override the entireViewPropTypesfile as it is a risk that things in react-native-windows fall out of sync with react-native.Fixes #15173