Fix touch target for views with z-index #13705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
cc @ayc1 |
facebook-github-bot
added
the
Import Started
|
@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: The new implementation of z-index did not handle touches properly. This fixes it by using the mapped child index like we do in `getChildDrawingOrder` in `TouchTargetHelper`. **Test plan** Tested that touchables work properly inside sticky headers (it uses z-index) on Android. Closes facebook#13705 Reviewed By: AaaChiuuu Differential Revision: D4987964 Pulled By: sahrens fbshipit-source-id: 165f98e23d2f304c4dc87f536c22b68a8923d806
brentvatne
pushed a commit
to expo/react-native
that referenced
this pull request
May 12, 2017
Summary: The new implementation of z-index did not handle touches properly. This fixes it by using the mapped child index like we do in `getChildDrawingOrder` in `TouchTargetHelper`. **Test plan** Tested that touchables work properly inside sticky headers (it uses z-index) on Android. Closes facebook#13705 Reviewed By: AaaChiuuu Differential Revision: D4987964 Pulled By: sahrens fbshipit-source-id: 165f98e23d2f304c4dc87f536c22b68a8923d806
brentvatne
pushed a commit
to expo/react-native
that referenced
this pull request
May 12, 2017
Summary: The new implementation of z-index did not handle touches properly. This fixes it by using the mapped child index like we do in `getChildDrawingOrder` in `TouchTargetHelper`. **Test plan** Tested that touchables work properly inside sticky headers (it uses z-index) on Android. Closes facebook#13705 Reviewed By: AaaChiuuu Differential Revision: D4987964 Pulled By: sahrens fbshipit-source-id: 165f98e23d2f304c4dc87f536c22b68a8923d806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation of z-index did not handle touches properly. This fixes it by using the mapped child index like we do in
getChildDrawingOrderinTouchTargetHelper.Test plan
Tested that touchables work properly inside sticky headers (it uses z-index) on Android.