Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Consolidate Running on Device (Android|iOS) Guides into one #10726

Closed
wants to merge 3 commits into from
Closed

[Docs] Consolidate Running on Device (Android|iOS) Guides into one #10726

wants to merge 3 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Nov 3, 2016 •
edited
Loading

The RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @JoelMarcey and @lacker to be potential reviewers.

@hramos hramos changed the title [Docs] [WIP] Separate instructions for Linux and Windows/macOS [Docs] Consolidate Running on Device (Android|iOS) Guides into one Nov 4, 2016
@hramos
Copy link
Contributor Author

hramos commented Nov 4, 2016

This is now ready for review. As I went through the Running on Device (Android) and the Running on Device (iOS) guides, I found enough inconsistencies and stale instructions to justify rewriting both as a single guide. I am reusing the platform/OS selector from the Getting Started guide in this case, which allows the reader to see the instructions for their specific setup without visiting separate docs.

It can be hard to visualize what content appears under which section, so I have attached the following screenshots that demonstrate all possible combinations:

screencapture-localhost-8079-react-native-docs-running-on-device-html-1478286497504
screencapture-localhost-8079-react-native-docs-running-on-device-html-1478286490300
screencapture-localhost-8079-react-native-docs-running-on-device-html-1478286482338
screencapture-localhost-8079-react-native-docs-running-on-device-html-1478286475249
screencapture-localhost-8079-react-native-docs-running-on-device-html-1478286468079
screencapture-localhost-8079-react-native-docs-running-on-device-html-1478286462104

@hramos
Copy link
Contributor Author

hramos commented Nov 4, 2016

I removed the instructions for using a custom port as those are no longer up to date and need to be revised. I’ll add them back once #9145 is resolved.

@JoelMarcey
Copy link

Excellent!

@facebook-github-bot
Copy link
Contributor

@JoelMarcey has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mlguys pushed a commit to mlguys/react-native that referenced this pull request Nov 8, 2016
@hramos @mlguys
Consolidate Running on Device (Android|iOS) Guides into one
6641e8d 
Summary:
The RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.
Closes facebook#10726

Differential Revision: D4139089

Pulled By: JoelMarcey

fbshipit-source-id: cc57c1d7e3c9dec94e123c3597ac78b3efb15dd0
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Nov 10, 2016
@hramos
Consolidate Running on Device (Android|iOS) Guides into one
ec86dba 
Summary:
The RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.
Closes facebook/react-native#10726

Differential Revision: D4139089

Pulled By: JoelMarcey

fbshipit-source-id: cc57c1d7e3c9dec94e123c3597ac78b3efb15dd0
@hramos hramos added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 11, 2016
xixixao added a commit to xixixao/react-native that referenced this pull request Dec 26, 2016
@xixixao
Fix Running On Device guide for iOS
a325c2e 
facebook#10726 incorrectly shown Android instructions when iOS is selected (you can see it on the first screenshot in the pull-request). I removed those and added the old notice about WiFi and the hint to open the Developer Menu.

Doing this from web so won't be able to screenshot the results.
@xixixao xixixao mentioned this pull request Dec 26, 2016
Closed
DanielMSchmidt pushed a commit to DanielMSchmidt/react-native that referenced this pull request Jan 4, 2017
@hramos @DanielMSchmidt
Consolidate Running on Device (Android|iOS) Guides into one
c7a0906 
Summary:
The RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.
Closes facebook#10726

Differential Revision: D4139089

Pulled By: JoelMarcey

fbshipit-source-id: cc57c1d7e3c9dec94e123c3597ac78b3efb15dd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hramos @facebook-github-bot @JoelMarcey