Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebView] Allow passing allowsInlineMediaPlayback as a boolean #960

Closed
jonathanong opened this issue Apr 22, 2015 · 8 comments
Closed

[WebView] Allow passing allowsInlineMediaPlayback as a boolean #960

jonathanong opened this issue Apr 22, 2015 · 8 comments
Assignees
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@jonathanong
Copy link

currently doing adding _webView.allowsInlineMediaPlayback = YES; in RCTWebView.m to get around this.

https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIWebView_Class/#//apple_ref/occ/instp/UIWebView/allowsInlineMediaPlayback

@brentvatne
Copy link
Collaborator

@jonathanong - can you create a PR for this? seems like a simple change, you can refer to the recently pushed Native UI Components guide or ping me on irc @notbrent if you need a hand.

@erikdung
Copy link

Could you please show me where to add this in RTCWebView.m? Thanks

@brentvatne
Copy link
Collaborator

@erikdung - you can add that here: https://github.com/facebook/react-native/blob/master/React/Views/RCTWebView.m#L39 - but preferably we would have an option that we could just pass into the component to enable/disable that, I can do this later

@brentvatne brentvatne self-assigned this Apr 24, 2015
@erikdung
Copy link

Great. Thanks. I solved my problem when creating app with youtube videos. I disabled fullscreen mode.

@brentvatne brentvatne changed the title webview: allow passing allowsInlineMediaPlayback as a boolean [WebView] Allow passing allowsInlineMediaPlayback as a boolean May 28, 2015
@brentvatne brentvatne added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jun 18, 2015
@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@kaievns
Copy link

kaievns commented Oct 16, 2015

+1 can we make this happen? also while you're on it, could you add an option for mediaPlaybackRequiresUserAction

@brentvatne
Copy link
Collaborator

@madrabbit - PR welcome!

@chirag04
Copy link
Contributor

7da42e3 added option for allowsInlineMediaPlayback in webView.

@jonathanong closing this in favor of that commit. Let me know if we need to reopen this.

@madrabbit Can you open a separate issue for mediaPlaybackRequiresUserAction and possibly PR?

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants