[Android] should i call Fresco.shutDown() in reactActivity.onDestroy()

[JuanbingTeam]

I tried the following steps:

1. start my RN app
2. exit by pressing back button
3. repeat 1,2 for several times

I found the memory keep increasing , and finally it lead to an OOM Exception.
With the help of AndroidStudio Monitor View, i found too many bitmaps were cached.

I tried to call Fresco.shutdown() manually in onDestroy, it seems better.

`@Override
protected void onDestroy() {

super.onDestroy();
Fresco.shutDown(); // call shutdown manually
if (mReactInstanceManager != null) {
mReactInstanceManager.destroy();
}
}`

Here are my questions:

1. When will the images cached by Fresco be recycled?
2. Do I need to release images manually?

Thanks guys....

[oprisnik]

This could be related to #8677. In theory, you should not need to do anything manually.

[norman-kapschefsky]

Have to clear Fresco stuff as well in onDestroy() of ReactActivity. Without it the memory of app process gets higher and higher wenn starting and closing the app frequently. With the following lines of code the problem is gone. Should be investigated in more detail because that is critical I guess.

@Override
protected void onDestroy() {
    super.onDestroy();

    Fresco.getImagePipeline().clearMemoryCaches();
    Fresco.shutDown();
}

[oprisnik]

This should have been fixed with recent React Native versions. RN was re-initializing Fresco which lead to these issues.

[JuanbingTeam]

Thanks @oprisnik & @norman-kapschefsky , I will do more tests with latest version.

[ericnakagawa]

Hi @JuanbingTeam I'll be closing this issue since there has been several updated versions of RN.

[JuanbingTeam]

thank you, yes ,this has been fixed~