Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensions.addEventListener not firing react native 0.74.3 #45497

Closed
sedatb opened this issue Jul 17, 2024 · 9 comments
Closed

Dimensions.addEventListener not firing react native 0.74.3 #45497

sedatb opened this issue Jul 17, 2024 · 9 comments
Labels
API: Dimensions Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue.

Comments

@sedatb
Copy link

sedatb commented Jul 17, 2024

Description

I tried IOS tablet devices but Dimensions.addEventListener not firing in react native 0.74.3
Works fine on iPhones. On tablets, when I change orientation, it doesn't firing.

Steps to reproduce

  1. Play video
  2. Change orientation on tablet
  3. Not firing dimension eventListener

React Native Version

0.74.3

Affected Platforms

Runtime - iOS

Output of npx react-native info

System:
  OS: macOS 14.4.1
  CPU: (10) arm64 Apple M2 Pro
  Memory: 851.80 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.0.0
    path: /var/folders/7k/zzwy60lx4m755sl1419v7x500000gn/T/yarn--1721225982346-0.35930533064896863/node
  Yarn:
    version: 1.22.22
    path: /var/folders/7k/zzwy60lx4m755sl1419v7x500000gn/T/yarn--1721225982346-0.35930533064896863/yarn
  npm:
    version: 10.5.1
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2024.04.29.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.3 AI-233.14808.21.2331.11842104
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.0
    wanted: 0.74.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

Not crash log

Reproducer

https://github.com/facebook/react-native

Screenshots and Videos

No response

@react-native-bot react-native-bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Jul 17, 2024
@react-native-bot
Copy link
Collaborator

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:

@migueldaipre
Copy link
Collaborator

Please add a reproducer

@sedatb
Copy link
Author

sedatb commented Jul 18, 2024

I use splashViewController to play gif in my splash screen. I tried to remove it in appDelegate then it worked. In appDelegate, when I use this code block, listener works perfectly,

bool didFinish = [super application:application didFinishLaunchingWithOptions:launchOptions];
return didFinish;

but when I use -> return YES;
listener doesnt't works truely.

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Jul 18, 2024
@cortinico cortinico added Needs: Author Feedback and removed Needs: Attention Issues where the author has responded to feedback. labels Jul 18, 2024
@cortinico
Copy link
Contributor

I use splashViewController to play gif in my splash screen. I tried to remove it in appDelegate then it worked. In appDelegate, when I use this code block, listener works perfectly,

bool didFinish = [super application:application didFinishLaunchingWithOptions:launchOptions]; return didFinish;

but when I use -> return YES; listener doesnt't works truely.

We need a GitHub repo that consistently reproduces your issue. You can use this template:
https://github.com/react-native-community/reproducer-react-native

@react-native-bot
Copy link
Collaborator

This issue is waiting for author's feedback since 24 days. Please provide the requested feedback or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Aug 12, 2024
@react-native-bot
Copy link
Collaborator

This issue is waiting for author's feedback since 24 days. Please provide the requested feedback or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Sep 5, 2024
@react-native-bot
Copy link
Collaborator

This issue is waiting for author's feedback since 24 days. Please provide the requested feedback or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Sep 30, 2024
@cortinico
Copy link
Contributor

Closing as @sedatb is unresponsive and a valid reproducer was never provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Dimensions Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue.
Projects
None yet
Development

No branches or pull requests

4 participants