-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for textAlign:start/end #45255
Comments
Hello, Can I try to resolve this issue? |
@cortinico I can pick this up, but had a few points. If we are to match web specs, then the way According to the CSS spec:
Based on this, I can see two ways to do it:
Which one would you recommend? |
those are good questions for @necolas |
@necolas whenever you can, if you can validate these points then I will make the fix accordingly. I have already done the same for Android, but awaiting confirmation will do the for iOS. |
Fixing this might be a breaking change if you're saying
I think the fix to the way |
What do you recommend? I am particularly referring to these lines: Lines 282 to 292 in 33262c1
I suspect something similar will also be there for iOS. If we add |
The above code mentioned is unfortunately only used in the legacy architecture. The new architecture has a different path for setting text direction, though I think it may also do some swapping (though IIRC maybe only when |
@NickGerleman in that case, can you point me to where this would be? @necolas Should the fix for this be inline with CSS spec? If so then I will start accordingly. |
@necolas Hello, any update on this? I can pick this up accordingly. |
Yes, inline with CSS spec |
Cool, sorry for the delay was unwell. I'll pick this up over this weekend! |
Description
React Native is missing support for
textAlign:start
andtextAlign:end
on Text and TextInput elements - https://developer.mozilla.org/en-US/docs/Web/CSS/text-align#syntaxThese values are important for supporting RTL layouts, and should react to the
direction
style on ancestral Views on all platforms.Steps to reproduce
React Native Version
0.75
Affected Platforms
Runtime - Android, Runtime - iOS
Output of
npx react-native info
Stacktrace or Logs
Reproducer
.
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: