Regression -- 0.72 fails to compile on iOS with use_frameworks! :linkage => :static when using pnpm

[evelant]

New Version

0.72.1

Old Version

0.71.11

Build Target(s)

iOS development

Output of react-native info

info Fetching system and libraries information...
System:
  OS: macOS 13.4
  CPU: (10) arm64 Apple M1 Pro
  Memory: 63.72 MB / 16.00 GB
  Shell:
    version: 0.80.0
    path: /Users/imagio/.cargo/bin/nu
Binaries:
  Node:
    version: 18.16.0
    path: ~/Library/Caches/fnm_multishells/62216_1687887822404/bin/node
  Yarn:
    version: 1.22.19
    path: ~/Library/pnpm/yarn
  npm:
    version: 9.7.2
    path: ~/Library/pnpm/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.11.3
    path: /Users/imagio/.asdf/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK: Not Found
IDEs:
  Android Studio: Flamingo 2022.2.1 Patch 2 Flamingo 2022.2.1 Patch 2
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.4.1
    path: /usr/bin/javac
  Ruby:
    version: 3.1.2
    path: /Users/imagio/.asdf/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.1
    wanted: 0.72.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Issue and Reproduction Steps

Reproduction: https://github.com/evelant/rn072-pnpm-monorepo-ios-frameworks-static-bug

React-native 0.72 fails to compile for iOS when using use_frameworks! :linkage => :static

The following build commands failed:
	CompileC /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-aijjqxpffhriwvdbnbtslrapnlmx/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.o /Users/imagio/dev/test/node_modules/.pnpm/react-native@0.72.1_@babel+core@7.20.2_@babel+preset-env@7.20.2_react@18.2.0/node_modules/react-native/ReactCommon/react/utils/RunLoopObserver.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'React-utils' from project 'Pods')
(1 failure)

To reproduce:
pnpm install
cd apps/testproj/ios
USE_FRAMEWORKS=static pod install
cd ..
pnpm react-native run-ios

[cipolleschi]

We have tests in CI that checks that the static frameworks builds (e.g.: Old Arch, Static Frameworks and Old Arch, dynamic frameworks)
and they work on the new arch as well (e.g.: Hermes, JSC)

These create a new app from the templates and install the pods accordingly, so that shouldn't happen.
Could it be a problem of pnpm? That's a setup we are actually not testing.

Also, this error:

The following build commands failed:
	CompileC /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-aijjqxpffhriwvdbnbtslrapnlmx/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.o /Users/imagio/dev/test/node_modules/.pnpm/react-native@0.72.1_@babel+core@7.20.2_@babel+preset-env@7.20.2_react@18.2.0/node_modules/react-native/ReactCommon/react/utils/RunLoopObserver.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'React-utils' from project 'Pods')
(1 failure)

Doesn't really told us anything: it only says that it failed to build RunLoopObserver.cpp but not why... :/

Could you provide the whole build log, uploading it somewhere?

[evelant]

@cipolleschi apologies! I copy pasted the wrong snippet 🤦

The failure in RunLoopObserver.cpp is 'react/debug/react_native_assert.h' file not found.

CompileC /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.o /Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/node_modules/.pnpm/react-native@0.72.1_@babel+core@7.20.2_@babel+preset-env@7.20.2_react@18.2.0/node_modules/react-native/ReactCommon/react/utils/RunLoopObserver.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'React-utils' from project 'Pods')
    cd /Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/ios/Pods
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -ivfsstatcache /Users/imagio/Library/Developer/Xcode/DerivedData/SDKStatCaches.noindex/iphonesimulator16.4-20E238-.sdkstatcache -target arm64-apple-ios12.4-simulator -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -std\=c++17 -stdlib\=libc++ -fmodules -gmodules -fmodules-cache-path\=/Users/imagio/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/imagio/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -fmodule-name\=React_utils -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Werror\=deprecated-objc-isa-usage -Werror\=objc-root-class -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -Wno-implicit-fallthrough -DPOD_CONFIGURATION_DEBUG\=1 -DDEBUG\=1 -DCOCOAPODS\=1 -D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator16.4.sdk -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -g -fvisibility-inlines-hidden -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Index.noindex/DataStore -iquote /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/React_utils-generated-files.hmap -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/React_utils-own-target-headers.hmap -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/React_utils-all-non-framework-target-headers.hmap -ivfsoverlay /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/all-product-headers.yaml -iquote /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/React_utils-project-headers.hmap -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/React-utils/include -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/ReactCommon-Samples/ReactCommon_Samples.framework/Headers -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/ReactCommon-Samples/ReactCommon_Samples.framework/Headers/platform/ios -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/React-NativeModulesApple/React_NativeModulesApple.framework/Headers -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/React-graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios -I/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/ios/Pods/RCT-Folly -I/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/node_modules/react-native/ReactCommon/react/utils -I/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/node_modules/react-native/ReactCommon/react/utils/ReactCommon -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/React-debug/React_debug.framework/Headers -I/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/ios/Pods/RCT-Folly -I/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/ios/Pods/DoubleConversion -I/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/ios/Pods/boost -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/DerivedSources-normal/arm64 -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/DerivedSources/arm64 -I/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/DerivedSources -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/React-utils -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/DoubleConversion -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/RCT-Folly -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/React-debug -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/fmt -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/glog -F/Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Products/Debug-iphonesimulator/libevent -DFOLLY_NO_CONFIG -DFOLLY_MOBILE\=1 -DFOLLY_USE_LIBCPP\=1 -Wno-comma -Wno-shorten-64-to-32 -include /Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/apps/testproj/ios/Pods/Target\ Support\ Files/React-utils/React-utils-prefix.pch -MMD -MT dependencies -MF /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.d --serialize-diagnostics /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.dia -c /Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/node_modules/.pnpm/react-native@0.72.1_@babel+core@7.20.2_@babel+preset-env@7.20.2_react@18.2.0/node_modules/react-native/ReactCommon/react/utils/RunLoopObserver.cpp -o /Users/imagio/Library/Developer/Xcode/DerivedData/testproj-apwspzmyimbgmwevshwwgfiakwkt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.o -index-unit-output-path /Pods.build/Debug-iphonesimulator/React-utils.build/Objects-normal/arm64/RunLoopObserver.o
/Users/imagio/dev/rn072-pnpm-monorepo-ios-frameworks-static-bug/node_modules/.pnpm/react-native@0.72.1_@babel+core@7.20.2_@babel+preset-env@7.20.2_react@18.2.0/node_modules/react-native/ReactCommon/react/utils/RunLoopObserver.cpp:10:10: fatal error: 'react/debug/react_native_assert.h' file not found
#include <react/debug/react_native_assert.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Here's a full build log: https://gist.github.com/evelant/2e1479de86cde27e287f07974c9b8d53

[evelant]

IIRC there was an issue with header paths that was pnpm specific in previous versions but it got fixed. Here it is: #34102

[evelant]

Here's the reproduction without using pnpm, same failure

https://github.com/evelant/rn072-ios-frameworks-static-failure

[cipolleschi]

can you try running USE_FRAMEWORKS=static NO_FLIPPER=1 pod install?
Flipper is not compatible with use_frameworks (and it will never be).

[evelant]

This is a pnpm issue -- failure is the same with NO_FLIPPER=1 on the pnpm reproduction. Most likely a resurfacing of #34102 due to how headers at symlinked paths in the pnpm store get copied

[evelant]

This is indeed the same issue as before. I don't remember how it got resolved unfortunately. The problem is that the headers get copied into the wrong directory:

[evelant]

Related commits and issues:

8131b7b
#25349

[evelant]

@cipolleschi I found and fixed the issue, although I'm not sure if my solution is ideal.

The problem is that cocoapods doesn't resolve the symlink when header_mappings_dir is set in the podspec. That causes headers to get copied as a relative path to the inside of the pnpm store instead of to their actual output directory. You end up with headers in Build/node_modules/.pnpm/react-native/node_modules/react-native/ReactCommon/react/...etc instead of in the framework dirs.

To fix this I altered the podspecs to resolve the absolute paths for header_mappings_dir. I also fixed a number of search paths that didn't work correctly (I think they may have always been incorrect but worked by luck with yarn).

Here's a patch
react-native@0.72.1.patch

[Janak-Nirmal]

@evelant how to apply above patch ? when tried with patch-package it says invalid patch file