-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: mention Modal state:modalVisible is required #3724
Labels
Comments
I'll actually change the default here, so the default value for visible is true. |
MattFoley
pushed a commit
to skillz/react-native
that referenced
this issue
Nov 9, 2015
Summary: Make <Modal> visible by default and fix the scenario where we present a modal immediately when adding it to the view hierarchy. Closes facebook#3724 Closes facebook#2952 public Reviewed By: nicklockwood Differential Revision: D2595938 fb-gh-sync-id: 1571790d36fe486f1fbbed9f2d66f1e6add73d91
Crash--
pushed a commit
to Crash--/react-native
that referenced
this issue
Dec 24, 2015
Summary: Make <Modal> visible by default and fix the scenario where we present a modal immediately when adding it to the view hierarchy. Closes facebook#3724 Closes facebook#2952 public Reviewed By: nicklockwood Differential Revision: D2595938 fb-gh-sync-id: 1571790d36fe486f1fbbed9f2d66f1e6add73d91
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
The following works
but if you remove this.state.modalVisible it does not work. I get
Exception thrown while executing UI block: Can't present modal view controller without a presenting view controller
. Either the docs should mention such a requirement or the error should be more descriptive.Ref: #2952
The text was updated successfully, but these errors were encountered: