Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build with XCode 14.0 #34673

Closed
alois-beto opened this issue Sep 13, 2022 · 40 comments
Closed

Unable to build with XCode 14.0 #34673

alois-beto opened this issue Sep 13, 2022 · 40 comments

Comments

@alois-beto
Copy link

Description

XCode 14.0 is released since yesterday, and I have the following error while building a fresh app on a physical device:

[...]/ios/Pods/Pods.xcodeproj error project: Signing for "React-Core-AccessibilityResources" requires a development team. Select a development team in the Signing & Capabilities editor.

Is react-native ready for XCode 14?

Version

0.70.0

Output of npx react-native info

System:
OS: macOS 12.5.1
CPU: (10) arm64 Apple M1 Pro
Memory: 6.53 GB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
Yarn: Not Found
npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
Watchman: 2022.08.29.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8815526
Xcode: 14.0/14A309 - /usr/bin/xcodebuild
Languages:
Java: 11.0.16.1 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.0 => 0.70.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Steps to reproduce

  • Create a fresh react-native app with npx react-native init MyApp
  • Open XCode and try to build the app on a real device

Snack, code example, screenshot, or link to a repository

https://github.com/BeTomorrow/react-native-file-logger/tree/master/example
Capture d’écran 2022-09-13 à 12 53 28

@Thanaen
Copy link

Thanaen commented Sep 13, 2022

I also tried to compile the application in "any device" mode (so not specifically for a physical device), and I get the same error in XCode 14.

Manually selecting a team for this pod seems to solve the problem.
However, I am not sure if this workaround has any side effects.

@almeidabbm
Copy link

almeidabbm commented Sep 13, 2022

I also tried to compile the application in "any device" mode (so not specifically for a physical device), and I get the same error in XCode 14.

Manually selecting a team for this pod seems to solve the problem. However, I am not sure if this workaround has any side effects.

I tried setting the team manually and was able to build the app. But somehow the globals declared in babel.config.js failed with ReferenceError: Can't find variable: <variable_name>. I had this issue with __scanCodes from https://github.com/rodgomesc/vision-camera-code-scanner.

As expected reverting XCode to version 13.4.1 fixed all of the above.

@pnthach95
Copy link

I use this script and it works

@fabiendem
Copy link

From #34673 (comment).
What does CODE_SIGNING_ALLOWED do? Isn't it needed?

@danilobuerger
Copy link
Contributor

See CocoaPods/CocoaPods#11402

@Isaccobosio
Copy link

I use this script and it works

Does it work even for react-native apps?
My podFile has this line at the end

post_install do |installer|
    react_native_post_install(installer)
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
  end

How can I merge with that script?

@pnthach95
Copy link

How can I merge with that script?

Replace with this

  post_install do |installer|
    react_native_post_install(installer)
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
    installer.pods_project.targets.each do |target|
      if target.respond_to?(:product_type) and target.product_type == "com.apple.product-type.bundle"
        target.build_configurations.each do |config|
            config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
        end
      end
    end
  end

@relez
Copy link

relez commented Sep 15, 2022

My workaround was to specify the TEAM_ID, my lines looks like this:

post_install do |installer|
  react_native_post_install(installer)
  __apply_Xcode_12_5_M1_post_install_workaround(installer)
  # Add these lines for Xcode 14 builds
  installer.generated_projects.each do |project|
    project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings["DEVELOPMENT_TEAM"] = "TEAM_ID"
        end
    end
  end
  # End of added lines
end

I hope it helps!

@pinokyov
Copy link

I solved this problem select development team.

@hakansaglam29
Copy link

hakansaglam29 commented Sep 16, 2022

How can I merge with that script?

  post_install do |installer|
    react_native_post_install(installer)
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
    installer.pods_project.build_configurations.each do |config|
        config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
    end
  end

you can change your script also like this.

@sunchanras
Copy link

@hakansaglam29 I got

How can I merge with that script?

  post_install do |installer|
    react_native_post_install(installer)
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
    installer.pods_project.build_configurations.each do |config|
        config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
    end
  end

you can change your script also like this.

I got no bitcode error on production build with bitcode enable.

@hugozerken
Copy link

same issue here, so how is the effection about setting CODE_SIGNING_ALLOWED = 'NO'

@Nerotox
Copy link

Nerotox commented Sep 20, 2022

My workaround was to specify the TEAM_ID, my lines looks like this:

post_install do |installer|
  react_native_post_install(installer)
  __apply_Xcode_12_5_M1_post_install_workaround(installer)
  # Add these lines for Xcode 14 builds
  installer.generated_projects.each do |project|
    project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings["DEVELOPMENT_TEAM"] = "TEAM_ID"
        end
    end
  end
  # End of added lines
end

I hope it helps!

Worked perfectly thanks!

If anyone else isn't sure where to get his team ID, it can be found on the apple developer website https://developer.apple.com/account/#/membership under the menu "Certificates, Identifiers & Profiles" and then look at the top right under your account name.

@davidking1234
Copy link

When implementing this fix, I am getting the following error:
"undefined method `react_native_post_install' for #Pod::Podfile:0x00007fea76758c18"

Is there something else we have to do to get that method to work?

Thanks in advance!

@breezertwo
Copy link

breezertwo commented Sep 21, 2022

@Nerotox

For me the string from the page would't be recognized by Xcode:
I needed my DEVELOPMENT_TEAM id from project.pbxproj file --> looked like this: 0A11BC2345

@christianrank
Copy link

christianrank commented Sep 21, 2022

I tried adding the fix mentioned here to the Podfile, and it worked locally.

But on the CI running on App Center for release builds, I am now getting this error:
/Users/runner/work/1/s/ios/Pods/Pods.xcodeproj: error: No signing certificate "iOS Development" found: No "iOS Development" signing certificate matching team ID "XXX" with a private key was found. (in target 'React-Core-AccessibilityResources' from project 'Pods')

Any ideas about that?

@Jin-seop
Copy link

xcode downgrade 13.4.1 version.

@christianrank
Copy link

Downgrade is not a real solution, only a quick fix.

@christianrank
Copy link

I found out this script actually works on my CI, just this doesn't.

@ansarikhurshid786
Copy link

ansarikhurshid786 commented Sep 26, 2022

i simply select provision profile and without clear build i can archive project it works for me.

@kelset
Copy link
Contributor

kelset commented Sep 27, 2022

can you folks try this workaround? expo/expo@d970a9e

it's the one the Expo team has been implementing and it seems to be in line with some comments in the pods issue.

@hamidhadi
Copy link

@kelset That workaround works for me.

@tomwanzek
Copy link

For current reference, we just ran into this issue when trying to upgrade our CI/CD pipeline to use

  • Fastlane 2.212.1
  • XCode 14.2

Incidentally, what seems to have made a difference is upgrading Cocoapods to 1.12.0. To be clear we did not add any of the workarounds in the Pod file post_install hooks as described earlier.

@liamjones
Copy link
Contributor

Incidentally, what seems to have made a difference is upgrading Cocoapods to 1.12.0. To be clear we did not add any of the workarounds in the Pod file post_install hooks as described earlier.

Yes, Cocoapods 1.12.0 contains a fix for this issue (although it was missing from the release notes): CocoaPods/CocoaPods@141a082

@penghuiliada
Copy link

penghuiliada commented Mar 24, 2023

For current reference, we just ran into this issue when trying to upgrade our CI/CD pipeline to use

  • Fastlane 2.212.1
  • XCode 14.2

Incidentally, what seems to have made a difference is upgrading Cocoapods to 1.12.0. To be clear we did not add any of the workarounds in the Pod file post_install hooks as described earlier.

Hi @tomwanzek , the cocoapods upgrade also helped us, now we can publish our app to TestFlight, but apple still complains that ITMS-90129: The bundle uses a bundle name or display name that is already taken., we didn't change any name for our app.

before upgrading cocoapods, we can't even publish to TestFlight, the publish step already failed with that error message.

do you have any idea?
Thanks! 🙏

@Harukisatoh
Copy link

For some reason upgrading cocoapods to 1.12.0 works locally, but doesn't work for AppCenter which is the CI I'm currently using. The post_install workaround also appears to not work for me.

@Harukisatoh
Copy link

For some reason upgrading cocoapods to 1.12.0 works locally, but doesn't work for AppCenter which is the CI I'm currently using. The post_install workaround also appears to not work for me.

For those who has the same issue as me:

Here's a link that explains the post install workaround: https://stackoverflow.com/a/39949186
After every pod install execution, the post install script is executed too. This script is used to disable the code signing on each pod library.

My problem was that this script was never being executed on CI. After a lot of hours trying to figure out why, I've finally found the cause in this link: https://learn.microsoft.com/en-us/appcenter/build/ios/#38-cocoapods
In the warning section they say: "If the repository already contains a /Pods folder, App Center assumes you've checked in the pods in your repository and will no longer perform pod install". And luckily (or no) in my repo I had the /Pods folder commited, and because of that, App Center never executed the script.

After that, the only thing I had to do was to execute a pod install locally, and commit all changes from /Pods folder to the repo, this way App Center received the already signed pods.

@tomwanzek
Copy link

@penghuiliada Unfortunately, I have not much to add about

TMS-90129: The bundle uses a bundle name or display name that is already taken.

It's an issue we have not encountered (so far 🤞). As you suggested with the "before upgrading cocoapods ", this seems to have been a preexisting issue and not a new one introduced with Cocoapods 1.12.0. Good luck, hope you find a solution.

@penghuiliada
Copy link

thank you @tomwanzek for checking!

Sorry, forgot to give update here, yes, it's indeed something wrong with our app, i documented the problem and solution here: CocoaPods/CocoaPods#11402 (comment)

In case someone has the same problem.

@kennedy-f
Copy link

Today, I encountered a similar issue and after inspecting the Expo code, I found a solution in their GitHub repository: https://github.com/expo/expo/blob/main/ios/Podfile#L78

To resolve my issue, I added the code snippet above to my Podfile, ran pod install again, and was able to successfully archive my application and distribute.

    react_native_post_install(
      installer,
      # Set `mac_catalyst_enabled` to `true` in order to apply patches
      # necessary for Mac Catalyst builds
      :mac_catalyst_enabled => false
    )
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
    
    installer.target_installation_results.pod_target_installation_results
         .each do |pod_name, target_installation_result|
      target_installation_result.resource_bundle_targets.each do |resource_bundle_target|
        resource_bundle_target.build_configurations.each do |config|
          config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
        end
      end
    end
  end

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this issue May 22, 2023
… for pods (facebook#34826)

Summary:
This is inspired by the Expo workaround expo/expo@d970a9e to address an issue that cocoapods has with Xcode 14: CocoaPods/CocoaPods#11402

This wants to address this facebook#34673 in a way that we can also cherry-pick on the 0.70 branch.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[iOS] [Fixed] - add xcode 14 workaround (turn off signing resource bundles) for `React-Core`

Pull Request resolved: facebook#34826

Test Plan:
Tested locally by opening RNTester via Xcode 14.0.1, and targetting my iPhone as device. After applying the patch, the error for React Core AccessibilityResources disappears.

Also, added ruby test for new patch.

Reviewed By: hramos

Differential Revision: D40063828

Pulled By: hramos

fbshipit-source-id: e10d5b6a917a6a7cbacd14ecfdac55e60e46c6f8
NicolasMassart added a commit to MetaMask/metamask-mobile that referenced this issue Jun 1, 2023
NicolasMassart added a commit to MetaMask/metamask-mobile that referenced this issue Jun 1, 2023
NicolasMassart added a commit to MetaMask/metamask-mobile that referenced this issue Jun 1, 2023
NicolasMassart added a commit to MetaMask/metamask-mobile that referenced this issue Jun 1, 2023
wachunei pushed a commit to MetaMask/metamask-mobile that referenced this issue Jun 6, 2023
wachunei pushed a commit to MetaMask/metamask-mobile that referenced this issue Jun 6, 2023
sethkfman pushed a commit to MetaMask/metamask-mobile that referenced this issue Jun 7, 2023
fixes issue while building iOS, see facebook/react-native#34673 (comment)

Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
sethkfman added a commit to MetaMask/metamask-mobile that referenced this issue Jun 20, 2023
* 7.1.0

* feat(release): 7.0.0 (#6465)

* 6.6.0

* notify appium server test is done (#6349)

* add tags and simplify feature description (#6353)

* [FIX] Appium: remove duplicate step onboarding (#6356)

* remove duplicated step

* configure smoke test for bitrise

* [FEAT] wallet connect v2 (#6355)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* Revert "[FEAT] wallet connect v2 (#6355)" (#6379)

This reverts commit 3911d7c.

* User can not longer edit account name to be an empty string (#6389)

* [FIX] [6.6.0] Block explorer name on Account Actions (#6390)

* block explorer name now it is correct on account actions sheet

* block explorer option only visible when it is defined

* Force Bitrise to build with intel medium stack machine (#6412)

* [FIX] - Fix input display when editing account name (#6413)

* remove height from input component

* update edit account name snapshot

* adding padding vertical 0 instead of removing height

* [FIX] [6.6.0] - Onboarding wizard misaligned (#6395)

* improvement on oboarding wizard to be more dynamic

* fix snapshot and fix unused import

* update text alignment

* onboarding more dynamic

* fix bug on android

* remove unused import

* New Crowdin translations by Github Action

* update translations

* update Animated Transaction Modal test

* update snapshot

---------

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>

* [FIX] [6.6.0] - Import tokens and NFTs button now visible  (#6431)

* import tokens and nfts visible

* nfts tab on wallet view with import NFTs visible

* [FIX] Send ETH displays Collectible as predefault value in the Amount screen and undefined balance (#6446)

* fix Send ETH displays as predefault value in the screen and balance

* added snapshot

* RC2 build 1113 (#6448)

* RC2 build 1113

* resolve yarn audit for socket.io-parser

---------

Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>

* Fix ENS name displayed on confirm send page (#6350) (#6456)

* build version bump to 1114 (#6460)

* 7.0.0

* [FEATURE] WalletConnect v2 Integration (#6380)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* bumps build number and adds Bitrise Intel force build fix

* feat: add big-integer dependency to avoid linting error

* feat: improve logging

* feat: handle dangling promises

* feat improve wc2 url parsing

* feat: store in env custom sdk env server

* feat: store in env custom sdk env server

* feat: use promise to get walletconnect instance

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat(CI): Convert Bitrise Workflows to Pipelines (#6366)

* add qa build pipeline

* update stage names

* removed utility workflow on slack notification

* removed utility workflow on slack notification

* add release build pipeline

* commented out RC trigger

* commented out triggers

* fix typo

* added comments and updated workflows

* formatting error for release announcement

* adding gradle caching

* added notes for QA test setup

* update deploy path

* add pulling pipeline files

* update artifact sources

* added E2E pipelines

* update notification to use pipeline title

* update view build pipeline

* updated deploy paths

* added pipeline deploy for intermediate files

* added intermediate files

* bumped machines

* format change

* disabled android for test

* updated artifact archives

* update deploy path for iOS

* updated deploy paths and machines

* updated deploy and release stages

* remove git info in notifies

* intermeidate files fix

* intermeidate files fix for iOS QA

* update trigger

* updated deploy xarchive

* removed symbol files from intermmediate builds

* removed symbol files from intermmediate builds

* added caching and optimize machine build times

* update failure slack notification

* removed unused get workflow info because of pipeline conversion

* updated triggers to use pipelines and added smoke pipeline trigger

---------

Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

* [FEAT] wc2 (#6492)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build 1117 RC3 (#6501)

* [FIX] wc2 integration with eth_sendTransaction (#6528)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

* fix: not waiting for transaction hash promise result

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build version bump to 1119 (#6531)

* adds try/catch to catch error in case of missing WCv2 missing ID (#6536)

* update changelog

* removed conflict tags

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: abretonc7s <arthur.breton@consensys.net>

* ci(bitrise): fix pod install step (#6543)

* remove sourcemaps from QA builds

* bump ruby version update and recreated podfile.lock

* bump cocoapods version

* remove cocoapods caching

* Revert "remove sourcemaps from QA builds"

This reverts commit 09a63f6.

* Revert "bump cocoapods version"

This reverts commit 6a2890c.

* revert podfile.lock changes

* upgrade to cocoapods 1.12.0 (#6512) (#6538)

fixes issue while building iOS, see facebook/react-native#34673 (comment)

Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>

* fix: [7.1.0] remove unicode chars from utf8 token symbol (#6508)

* patch to fix unicode on utf8 of token symbol

* Revert "patch to fix unicode on utf8 of token symbol"

This reverts commit 05dfee8.

* unicode path to assets contract controller

* Fix bug domain not shown on signature (#6464)

* Make sure origin is shown on SignatureRequest

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* if asset is undefined, show balance of selected account.

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* update snapshot

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* lint fix

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Test get balance if address is null

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* test show origin header

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Lint fixes

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Podfile fix

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Fix PR comment: Combine the ifs

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

---------

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* bugfix: fix for swaps button displaying on unsupported networks (#6473) (#6553)

Co-authored-by: Nicolas Ferro <nicolaspatricioferro@gmail.com>

* feat(release): 7.0.1 (#6556)

* 6.6.0

* notify appium server test is done (#6349)

* add tags and simplify feature description (#6353)

* [FIX] Appium: remove duplicate step onboarding (#6356)

* remove duplicated step

* configure smoke test for bitrise

* [FEAT] wallet connect v2 (#6355)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* Revert "[FEAT] wallet connect v2 (#6355)" (#6379)

This reverts commit 3911d7c.

* User can not longer edit account name to be an empty string (#6389)

* [FIX] [6.6.0] Block explorer name on Account Actions (#6390)

* block explorer name now it is correct on account actions sheet

* block explorer option only visible when it is defined

* Force Bitrise to build with intel medium stack machine (#6412)

* [FIX] - Fix input display when editing account name (#6413)

* remove height from input component

* update edit account name snapshot

* adding padding vertical 0 instead of removing height

* [FIX] [6.6.0] - Onboarding wizard misaligned (#6395)

* improvement on oboarding wizard to be more dynamic

* fix snapshot and fix unused import

* update text alignment

* onboarding more dynamic

* fix bug on android

* remove unused import

* New Crowdin translations by Github Action

* update translations

* update Animated Transaction Modal test

* update snapshot

---------

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>

* [FIX] [6.6.0] - Import tokens and NFTs button now visible  (#6431)

* import tokens and nfts visible

* nfts tab on wallet view with import NFTs visible

* [FIX] Send ETH displays Collectible as predefault value in the Amount screen and undefined balance (#6446)

* fix Send ETH displays as predefault value in the screen and balance

* added snapshot

* RC2 build 1113 (#6448)

* RC2 build 1113

* resolve yarn audit for socket.io-parser

---------

Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>

* Fix ENS name displayed on confirm send page (#6350) (#6456)

* build version bump to 1114 (#6460)

* 7.0.0

* [FEATURE] WalletConnect v2 Integration (#6380)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* bumps build number and adds Bitrise Intel force build fix

* feat: add big-integer dependency to avoid linting error

* feat: improve logging

* feat: handle dangling promises

* feat improve wc2 url parsing

* feat: store in env custom sdk env server

* feat: store in env custom sdk env server

* feat: use promise to get walletconnect instance

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat(CI): Convert Bitrise Workflows to Pipelines (#6366)

* add qa build pipeline

* update stage names

* removed utility workflow on slack notification

* removed utility workflow on slack notification

* add release build pipeline

* commented out RC trigger

* commented out triggers

* fix typo

* added comments and updated workflows

* formatting error for release announcement

* adding gradle caching

* added notes for QA test setup

* update deploy path

* add pulling pipeline files

* update artifact sources

* added E2E pipelines

* update notification to use pipeline title

* update view build pipeline

* updated deploy paths

* added pipeline deploy for intermediate files

* added intermediate files

* bumped machines

* format change

* disabled android for test

* updated artifact archives

* update deploy path for iOS

* updated deploy paths and machines

* updated deploy and release stages

* remove git info in notifies

* intermeidate files fix

* intermeidate files fix for iOS QA

* update trigger

* updated deploy xarchive

* removed symbol files from intermmediate builds

* removed symbol files from intermmediate builds

* added caching and optimize machine build times

* update failure slack notification

* removed unused get workflow info because of pipeline conversion

* updated triggers to use pipelines and added smoke pipeline trigger

---------

Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

* [FEAT] wc2 (#6492)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build 1117 RC3 (#6501)

* [FIX] wc2 integration with eth_sendTransaction (#6528)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

* fix: not waiting for transaction hash promise result

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build version bump to 1119 (#6531)

* 7.0.1

* refactor(whats-new-modal): remove onramp content (#6558)

refactor(whats-new-modal): remove onramp translations

* updated changelog

* update changelog

* fix release announcement bitrise step

* resolve merge conflicts between 7.0.1 and 7.1.0 (#6565)

* fix yarn

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>

* fix: [7.1.0] Account incorrectly displayed on transaction review modal (#6502)

* reset transaction when leave the send flow

* Disable navigating back on send flow to force user to reset the transaction when exit the send flow

* Disabling swipe down on IOS

* build 1127 RC2 (#6572)

* chore: pending review feedback for token details related changes (#6530) (#6578)

* chore: pending review feedback for token details related changes

* chore: updating styles for footer border

* remvoe what's new modal step from feature files (#6580)

* fix: Fix upgrade logout error on 7.1.0 (#6627)

* updated migration script to check before assigning

* bump version

* added return statement to migration 16 instance

* bump version for test build

* bumped VERSION_NUMBER to 1136 (#6640)

* bumped VERSION_NUMBER in gradle and pbxproj to 1136 (#6642)

* upated change-log

* chore: merge main into release branch (#6648)

---------

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: Olusegun Akintayo <trinisoftinc@gmail.com>
Co-authored-by: Curtis David <Curtis.David7@gmail.com>
Co-authored-by: Nicolas Ferro <nicolaspatricioferro@gmail.com>
Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
leotm pushed a commit to MetaMask/metamask-mobile that referenced this issue Jun 28, 2023
* 7.1.0

* feat(release): 7.0.0 (#6465)

* 6.6.0

* notify appium server test is done (#6349)

* add tags and simplify feature description (#6353)

* [FIX] Appium: remove duplicate step onboarding (#6356)

* remove duplicated step

* configure smoke test for bitrise

* [FEAT] wallet connect v2 (#6355)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* Revert "[FEAT] wallet connect v2 (#6355)" (#6379)

This reverts commit 3911d7c.

* User can not longer edit account name to be an empty string (#6389)

* [FIX] [6.6.0] Block explorer name on Account Actions (#6390)

* block explorer name now it is correct on account actions sheet

* block explorer option only visible when it is defined

* Force Bitrise to build with intel medium stack machine (#6412)

* [FIX] - Fix input display when editing account name (#6413)

* remove height from input component

* update edit account name snapshot

* adding padding vertical 0 instead of removing height

* [FIX] [6.6.0] - Onboarding wizard misaligned (#6395)

* improvement on oboarding wizard to be more dynamic

* fix snapshot and fix unused import

* update text alignment

* onboarding more dynamic

* fix bug on android

* remove unused import

* New Crowdin translations by Github Action

* update translations

* update Animated Transaction Modal test

* update snapshot

---------

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>

* [FIX] [6.6.0] - Import tokens and NFTs button now visible  (#6431)

* import tokens and nfts visible

* nfts tab on wallet view with import NFTs visible

* [FIX] Send ETH displays Collectible as predefault value in the Amount screen and undefined balance (#6446)

* fix Send ETH displays as predefault value in the screen and balance

* added snapshot

* RC2 build 1113 (#6448)

* RC2 build 1113

* resolve yarn audit for socket.io-parser

---------

Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>

* Fix ENS name displayed on confirm send page (#6350) (#6456)

* build version bump to 1114 (#6460)

* 7.0.0

* [FEATURE] WalletConnect v2 Integration (#6380)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* bumps build number and adds Bitrise Intel force build fix

* feat: add big-integer dependency to avoid linting error

* feat: improve logging

* feat: handle dangling promises

* feat improve wc2 url parsing

* feat: store in env custom sdk env server

* feat: store in env custom sdk env server

* feat: use promise to get walletconnect instance

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat(CI): Convert Bitrise Workflows to Pipelines (#6366)

* add qa build pipeline

* update stage names

* removed utility workflow on slack notification

* removed utility workflow on slack notification

* add release build pipeline

* commented out RC trigger

* commented out triggers

* fix typo

* added comments and updated workflows

* formatting error for release announcement

* adding gradle caching

* added notes for QA test setup

* update deploy path

* add pulling pipeline files

* update artifact sources

* added E2E pipelines

* update notification to use pipeline title

* update view build pipeline

* updated deploy paths

* added pipeline deploy for intermediate files

* added intermediate files

* bumped machines

* format change

* disabled android for test

* updated artifact archives

* update deploy path for iOS

* updated deploy paths and machines

* updated deploy and release stages

* remove git info in notifies

* intermeidate files fix

* intermeidate files fix for iOS QA

* update trigger

* updated deploy xarchive

* removed symbol files from intermmediate builds

* removed symbol files from intermmediate builds

* added caching and optimize machine build times

* update failure slack notification

* removed unused get workflow info because of pipeline conversion

* updated triggers to use pipelines and added smoke pipeline trigger

---------

Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

* [FEAT] wc2 (#6492)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build 1117 RC3 (#6501)

* [FIX] wc2 integration with eth_sendTransaction (#6528)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

* fix: not waiting for transaction hash promise result

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build version bump to 1119 (#6531)

* adds try/catch to catch error in case of missing WCv2 missing ID (#6536)

* update changelog

* removed conflict tags

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: abretonc7s <arthur.breton@consensys.net>

* ci(bitrise): fix pod install step (#6543)

* remove sourcemaps from QA builds

* bump ruby version update and recreated podfile.lock

* bump cocoapods version

* remove cocoapods caching

* Revert "remove sourcemaps from QA builds"

This reverts commit 09a63f6.

* Revert "bump cocoapods version"

This reverts commit 6a2890c.

* revert podfile.lock changes

* upgrade to cocoapods 1.12.0 (#6512) (#6538)

fixes issue while building iOS, see facebook/react-native#34673 (comment)

Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>

* fix: [7.1.0] remove unicode chars from utf8 token symbol (#6508)

* patch to fix unicode on utf8 of token symbol

* Revert "patch to fix unicode on utf8 of token symbol"

This reverts commit 05dfee8.

* unicode path to assets contract controller

* Fix bug domain not shown on signature (#6464)

* Make sure origin is shown on SignatureRequest

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* if asset is undefined, show balance of selected account.

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* update snapshot

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* lint fix

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Test get balance if address is null

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* test show origin header

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Lint fixes

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Podfile fix

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* Fix PR comment: Combine the ifs

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

---------

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>

* bugfix: fix for swaps button displaying on unsupported networks (#6473) (#6553)

Co-authored-by: Nicolas Ferro <nicolaspatricioferro@gmail.com>

* feat(release): 7.0.1 (#6556)

* 6.6.0

* notify appium server test is done (#6349)

* add tags and simplify feature description (#6353)

* [FIX] Appium: remove duplicate step onboarding (#6356)

* remove duplicated step

* configure smoke test for bitrise

* [FEAT] wallet connect v2 (#6355)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* Revert "[FEAT] wallet connect v2 (#6355)" (#6379)

This reverts commit 3911d7c.

* User can not longer edit account name to be an empty string (#6389)

* [FIX] [6.6.0] Block explorer name on Account Actions (#6390)

* block explorer name now it is correct on account actions sheet

* block explorer option only visible when it is defined

* Force Bitrise to build with intel medium stack machine (#6412)

* [FIX] - Fix input display when editing account name (#6413)

* remove height from input component

* update edit account name snapshot

* adding padding vertical 0 instead of removing height

* [FIX] [6.6.0] - Onboarding wizard misaligned (#6395)

* improvement on oboarding wizard to be more dynamic

* fix snapshot and fix unused import

* update text alignment

* onboarding more dynamic

* fix bug on android

* remove unused import

* New Crowdin translations by Github Action

* update translations

* update Animated Transaction Modal test

* update snapshot

---------

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>

* [FIX] [6.6.0] - Import tokens and NFTs button now visible  (#6431)

* import tokens and nfts visible

* nfts tab on wallet view with import NFTs visible

* [FIX] Send ETH displays Collectible as predefault value in the Amount screen and undefined balance (#6446)

* fix Send ETH displays as predefault value in the screen and balance

* added snapshot

* RC2 build 1113 (#6448)

* RC2 build 1113

* resolve yarn audit for socket.io-parser

---------

Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>

* Fix ENS name displayed on confirm send page (#6350) (#6456)

* build version bump to 1114 (#6460)

* 7.0.0

* [FEATURE] WalletConnect v2 Integration (#6380)

* feat: wc2 integration

* chore: remove unnecessary console logs

* chore: cleanup

* refactor: move WalletConnect.js to WalletConnect folder

* feat: restore comm layer to 0.2.2

* fix: import path

* fix: unit tests for wc1

* feat: default session value to id

* feat: prevent display loading modal until unlocked

* feat: improve url/title display to occupy all space

* feat: use originator platforminfo

* feat: update comm layer to 0.2.4

* feat: force bigint big-integer polyfill on android

* feat: force hide loading state function

* feat: add request_source to views approval and senflow confirm

* bumps build number and adds Bitrise Intel force build fix

* feat: add big-integer dependency to avoid linting error

* feat: improve logging

* feat: handle dangling promises

* feat improve wc2 url parsing

* feat: store in env custom sdk env server

* feat: store in env custom sdk env server

* feat: use promise to get walletconnect instance

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat(CI): Convert Bitrise Workflows to Pipelines (#6366)

* add qa build pipeline

* update stage names

* removed utility workflow on slack notification

* removed utility workflow on slack notification

* add release build pipeline

* commented out RC trigger

* commented out triggers

* fix typo

* added comments and updated workflows

* formatting error for release announcement

* adding gradle caching

* added notes for QA test setup

* update deploy path

* add pulling pipeline files

* update artifact sources

* added E2E pipelines

* update notification to use pipeline title

* update view build pipeline

* updated deploy paths

* added pipeline deploy for intermediate files

* added intermediate files

* bumped machines

* format change

* disabled android for test

* updated artifact archives

* update deploy path for iOS

* updated deploy paths and machines

* updated deploy and release stages

* remove git info in notifies

* intermeidate files fix

* intermeidate files fix for iOS QA

* update trigger

* updated deploy xarchive

* removed symbol files from intermmediate builds

* removed symbol files from intermmediate builds

* added caching and optimize machine build times

* update failure slack notification

* removed unused get workflow info because of pipeline conversion

* updated triggers to use pipelines and added smoke pipeline trigger

---------

Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

* [FEAT] wc2 (#6492)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build 1117 RC3 (#6501)

* [FIX] wc2 integration with eth_sendTransaction (#6528)

* feat: wc2 integration

* feat: prevent display loading modal until unlocked

* feat: use originator platforminfo

* feat: force bigint big-integer polyfill on android

* bumps build number and adds Bitrise Intel force build fix

* feat: store in env custom sdk env server

* feat: update to latest wc se-sdk

* feat: update to latest wc se-sdk

* chore: linting

* feat: update dependencies

* fix: issue with eth_sendTransaction

* chore: remove duplicate imports

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* fix: error while rebasing

* chore: edit js env

* docs: add wallet connect project id info

* fix: not waiting for transaction hash promise result

---------

Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>

* build version bump to 1119 (#6531)

* 7.0.1

* refactor(whats-new-modal): remove onramp content (#6558)

refactor(whats-new-modal): remove onramp translations

* updated changelog

* update changelog

* fix release announcement bitrise step

* resolve merge conflicts between 7.0.1 and 7.1.0 (#6565)

* fix yarn

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>

* fix: [7.1.0] Account incorrectly displayed on transaction review modal (#6502)

* reset transaction when leave the send flow

* Disable navigating back on send flow to force user to reset the transaction when exit the send flow

* Disabling swipe down on IOS

* build 1127 RC2 (#6572)

* chore: pending review feedback for token details related changes (#6530) (#6578)

* chore: pending review feedback for token details related changes

* chore: updating styles for footer border

* remvoe what's new modal step from feature files (#6580)

* fix: Fix upgrade logout error on 7.1.0 (#6627)

* updated migration script to check before assigning

* bump version

* added return statement to migration 16 instance

* bump version for test build

* bumped VERSION_NUMBER to 1136 (#6640)

* bumped VERSION_NUMBER in gradle and pbxproj to 1136 (#6642)

* upated change-log

* chore: merge main into release branch (#6648)

---------

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
Co-authored-by: abretonc7s <107169956+abretonc7s@users.noreply.github.com>
Co-authored-by: Andrea Salvatore <andrea.salvatore@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Co-authored-by: sethkfman <Seth.Kaufman@consensys.net>
Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>
Co-authored-by: abretonc7s <arthur.breton@consensys.net>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: Olusegun Akintayo <trinisoftinc@gmail.com>
Co-authored-by: Curtis David <Curtis.David7@gmail.com>
Co-authored-by: Nicolas Ferro <nicolaspatricioferro@gmail.com>
Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
@sanoofrahiman960
Copy link

post_install do |installer|
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end

1, when run i code " npx react-native run-ios"
i got error like this how to solve i stuck with 2 weeks
"
** BUILD FAILED **

The following build commands failed:
CompileC /Users/sanoofrahimanj/Library/Developer/Xcode/DerivedData/milmaDataEntry-awvvzufrdwnctpalvkdkgvyaxbpw/Build/Intermediates.noindex/milmaDataEntry.build/Debug-iphonesimulator/milmaDataEntry.build/Objects-normal/arm64/AppDelegate.o /Users/sanoofrahimanj/Desktop/Workspace/DonamsTechLabs/milma-pms-app/ios/milmaDataEntry/AppDelegate.mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'milmaDataEntry' from project 'milmaDataEntry')
(1 failure)"

my pod file attached below
Screenshot 2023-07-11 at 11 05 53 AM

my system info run :-npx react native info
System:
OS: macOS 12.5
CPU: (8) arm64 Apple M1
Memory: 107.86 MB / 8.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.17.1 - ~/.nvm/versions/node/v16.17.1/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 9.4.1 - ~/.nvm/versions/node/v16.17.1/bin/npm
Watchman: 2023.02.27.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.12.1 - /Users/sanoofrahimanj/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 19.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: ^18.1.0 => 18.2.0
react-native: ^0.70.6 => 0.70.12
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

@thellecodes
Copy link

Today, I encountered a similar issue and after inspecting the Expo code, I found a solution in their GitHub repository: https://github.com/expo/expo/blob/main/ios/Podfile#L78

To resolve my issue, I added the code snippet above to my Podfile, ran pod install again, and was able to successfully archive my application and distribute.

    react_native_post_install(
      installer,
      # Set `mac_catalyst_enabled` to `true` in order to apply patches
      # necessary for Mac Catalyst builds
      :mac_catalyst_enabled => false
    )
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
    
    installer.target_installation_results.pod_target_installation_results
         .each do |pod_name, target_installation_result|
      target_installation_result.resource_bundle_targets.each do |resource_bundle_target|
        resource_bundle_target.build_configurations.each do |config|
          config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
        end
      end
    end
  end

Worked for me 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests