Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchables dismiss sequential fast touches #32300

Closed
YassinEldeeb opened this issue Sep 30, 2021 · 7 comments
Closed

Touchables dismiss sequential fast touches #32300

YassinEldeeb opened this issue Sep 30, 2021 · 7 comments
Labels
Needs: Triage 🔍 Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@YassinEldeeb
Copy link

YassinEldeeb commented Sep 30, 2021

Description

I'm building a PIN Lock Screen for my cloud storage app, the screen is very simple.
the problem is that when typing the PIN Code at normal speed it's fine and it triggers all of my touches, but when typing the PIN Code fast as people usually do to prevent anyone from catching the PIN, it always triggers 2 or 3 out of 4 touches even in release mode.

  • any touchable component has that problem, it's not very slow but in a PIN Lock Screen scenario, it's notable that not all of my fast touches are triggered due to my fast touches.

React Native version:

System:
OS: Windows 10 10.0.19042
CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
Memory: 7.16 GB / 15.95 GB
Binaries:
Node: 16.8.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
npm: 7.21.0 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 23, 25, 27, 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 30.0.2
System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: Version 4.0.0.0 AI-193.6911.18.40.6626763
Visual Studio: 16.6.30225.117 (Visual Studio Community 2019)
Languages:
Java: 11.0.12 - /c/Program Files/Eclipse Foundation/jdk-11.0.12.7-hotspot/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: https://github.com/expo/react-native/archive/sdk-42.0.0.tar.gz => 0.63.2
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found

Steps To Reproduce

I've isolated that screen in a repo, and made that same PIN Lock Screen with minimal amount of code and no extra dependencies, so just those 3 commands will get you up and running with the problem.

It's just 12 touchable components and 4 dots above, when you tap on any touchable component it adds the value to the PINCode state, very simple.

  1. git clone https://github.com/YassinEldeeb/react-native-touchables-bug
  2. yarn
  3. yarn start
  4. as an example press 4 zeros fast, you'll notice only 2 or 3 are triggered, it only triggers all the touches if you wait after each press a bit.

Expected Results

I expected fast response as other native apps and the device lock screen, they've very fast response to my touches.

Snack, code example, screenshot, or link to a repository:

Snack: https://snack.expo.dev/@yassineldeeb/dcff5b
Minimal Code Example: https://github.com/YassinEldeeb/react-native-touchables-bug/blob/main/App.tsx
Repo: https://github.com/YassinEldeeb/react-native-touchables-bug

And this is a screen recording for the problem, if you put the playback speed on 0.25, you'll notice that I pressed certain numbers and it was dismissed by the touchable highlight tint color and the actual onPress event.

VID_20210930121250.mp4
@stale
Copy link

stale bot commented Jan 9, 2022

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 9, 2022
@YassinEldeeb
Copy link
Author

The Issue isn't fixed yet.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 10, 2022
@bna-ch
Copy link

bna-ch commented Jun 20, 2022

Did you find a solution to this? I am working on something similar and having the same issue.

Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 23, 2024
@YassinEldeeb
Copy link
Author

still not fixed

@github-actions github-actions bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 24, 2024
@react-native-bot
Copy link
Collaborator

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 20, 2024
@react-native-bot
Copy link
Collaborator

This issue was closed because it has been stalled for 7 days with no activity.

@react-native-bot react-native-bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants