Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android TextInput placeholder with custom font has incorrect height #31544

Open
computerjazz opened this issue May 18, 2021 · 3 comments
Open
Labels
Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project.

Comments

@computerjazz
Copy link

computerjazz commented May 18, 2021

Description

TextInput placeholders that do not use the default android font and differ in their wrap point from the default font may be cut off. For example, if the default font does not wrap, and the custom font is slightly wider and does wrap to the next line, the placeholder will NOT reflect this wrapping, and the TextInput will only be one line.

React Native version:

System:
    OS: macOS 11.2.3
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 91.84 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.0.0 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.10.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      API Levels: 28, 29, 30
      Build Tools: 28.0.3, 29.0.2, 30.0.3, 31.0.0
      System Images: android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.6953283
    Xcode: 12.4/12D4e - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.10 - /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1 
    react-native: 0.64.1 => 0.64.1 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

  • Create text input with placeholder string that does not wrap with default font, but does wrap with custom font.
  • Second line will not be visible.

Expected Results

Placeholder should adjust height according to its font.

Snack, code example, screenshot, or link to a repository:

https://snack.expo.io/@computerjazz/textinput-android-bug

expected behavior (in this case placeholder text is long enough that it ALSO would wrap using default font)
Screen Shot 2021-05-18 at 9 27 19

actual behavior (placeholder text using "serif" font wraps to a 3rd line, but if it were to use the default font it would not wrap, and as a result placeholder gets cut off):
Screen Shot 2021-05-18 at 9 22 40

For reference, here's the same text using default font, note that it does not wrap to a 3rd line:
Screen Shot 2021-05-18 at 9 30 30

@hardikshah197
Copy link

May I take up this issue? if it is open @computerjazz

@chrisglein chrisglein added the Component: TextInput Related to the TextInput component. label May 18, 2021
@chrisglein
Copy link

This looks similar to lots of other TextInput line height issues that have come through: #31112 or #30666 for example. @computerjazz do either of those look the same to you?

@chrisglein chrisglein added Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Needs: Author Feedback and removed Needs: Triage 🔍 labels May 18, 2021
@computerjazz
Copy link
Author

@chrisglein the issues you linked look related, but I don't think any of these is an actual duplication of this ticket.

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels May 18, 2021
@chrisglein chrisglein removed the Needs: Attention Issues where the author has responded to feedback. label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project.
Projects
None yet
Development

No branches or pull requests

3 participants