Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entrance/exit from collection Not supported by Flatlist #30964

Closed
amarlette opened this issue Feb 10, 2021 · 3 comments
Closed

Entrance/exit from collection Not supported by Flatlist #30964

amarlette opened this issue Feb 10, 2021 · 3 comments
Labels
Accessibility Component: FlatList Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications.

Comments

@amarlette
Copy link

amarlette commented Feb 10, 2021 •
edited
Loading

Description

Entrance/exit from collection Not supported by Flatlist. No components can be set as any collection role. With support for "List" or "Grid" roles would these would likely work as expected.

This issue is covered in-depth by parent issue #30861, please check there for more details.

React Native version:

0.63
@amarlette amarlette mentioned this issue Feb 10, 2021
Closed
4 tasks
@amarlette amarlette added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Mar 5, 2021
@anaskhraza
Copy link
Contributor

Hi @amarlette, I would like to contribute to this issue, can you please assign this to me?

@amarlette
Copy link
Author

amarlette commented May 26, 2021 •
edited
Loading

Thank you @anaskhraza for taking on this issue. I look forward to seeing your pull request! I have moved this issue into the "In-Progress" column.

@anaskhraza anaskhraza mentioned this issue May 29, 2021
Closed
@amarlette amarlette linked a pull request Jun 3, 2021 that will close this issue
Added Support for Entrance/exit from collection by Flatlist #31630
Closed
facebook-github-bot pushed a commit that referenced this issue Jul 10, 2021
@anaskhraza @facebook-github-bot
Added Support for Entrance/exit from collection by Flatlist (#31630)
25a1612 
Summary:
Issue #30964 .When using a screen reader, flatlist does not announce entrance/ exit from the flat list.

## Changelog

[Android] [Changed] - Added support for accessibility role of "list" for flatlist and sectioned list

Pull Request resolved: #31630

Test Plan: I have added accessibility role prop in flatlist and sectioned list in rntester app, that will announce entrance/ exit from flatlist and sectioned list.

Reviewed By: kacieb

Differential Revision: D29599351

Pulled By: blavalla

fbshipit-source-id: e16ec69a694780d12f15f88a1e6bb5d7d77ac15f
@gabrieldonadel
Copy link
Collaborator

@amarlette #31630 was merged a while ago, can we close this issue?

@aliossam aliossam closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Component: FlatList Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Support for Entrance/exit from collection by Flatlist anaskhraza/react-native
4 participants
@amarlette @gabrieldonadel @anaskhraza @aliossam