Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal closing caused Animated childs back to start value of animation #28133

Closed
NguyenHoangMinhkkkk opened this issue Feb 20, 2020 · 3 comments
Closed
Labels
Needs: Triage 🔍 Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@NguyenHoangMinhkkkk
Copy link

NguyenHoangMinhkkkk commented Feb 20, 2020

Description:

  • Modal closing caused Animated childs back to start value of animation.
  • Animating to translate child component to some coordinates(x,y) and After setState to close modal, child components inside be back to previous position

React Native version:
System:
OS: macOS 10.15.3
CPU: (6) x64 Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Memory: 511.51 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 13.6.0 - /usr/local/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.13.4 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 16, 18, 19, 21, 22, 23, 24, 26, 27, 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-19 | Google APIs Intel x86 Atom, android-21 | Google APIs Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64
IDEs:
Android Studio: 3.5 AI-191.8026.42.35.6010548
Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild

Steps To Reproduce

  • Toggle on modal
  • Translate child component
  • Toggle off modal
  • See what happens at closing moment

Expected Results

Child component's animation position stand at it's position on closing modal

Snack, code example, screenshot, or link to a repository:

Feb-21-2020 10-57-16

@NguyenHoangMinhkkkk
Copy link
Author

I found that this issue only happen when childs component's animation useNativeDriver:true.
So, anything works properly with useNativeDriver:false at child components.

  • but, why?

@stale
Copy link

stale bot commented May 22, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 22, 2020
@stale
Copy link

stale bot commented May 30, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed May 30, 2020
@facebook facebook locked as resolved and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Triage 🔍 Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

1 participant