Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android platform checks and possible irrelevant code paths still exist in this repo #269

Closed
jondot opened this issue Mar 26, 2015 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jondot
Copy link
Contributor

jondot commented Mar 26, 2015

See here

Libraries/Components/ScrollView/ScrollView.js
276:    } else if (Platform.OS === 'android') {
332:if (Platform.OS === 'android') {

And here

Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js
69:  if (Platform.OS === 'android') {

It's probably safe, because the codepath never executes on iOS, but still there's references to Android views which I'm sure are still internal and not open source.

@vjeux
Copy link
Contributor

vjeux commented Mar 27, 2015

We're not ready yet to be open source first so any pull request has to go through our internal codebase and pass our internal tests that include android. We want to open source android sooner than later so that it doesn't become a big issue but until then, we'll have to live with those checks i'm afraid :(

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants