Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal does not close when setting state to false IOS #25410

Closed
tshyti opened this issue Jun 26, 2019 · 4 comments
Closed

Modal does not close when setting state to false IOS #25410

tshyti opened this issue Jun 26, 2019 · 4 comments
Labels
Bug Component: Modal Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@tshyti
Copy link

tshyti commented Jun 26, 2019

Modal does not close when its visible state is set to false inside an async function.
this only happerns in IOS, in Android there are not problems

Steps To Reproduce

1.Set state to loading = true in async method
2.Set state to loading = false in try if request succeeds of fails

sync _www(walletId){
this.walletModal.setVisibleState(false);
this.setState({loading: true});

    const {fature} = this.state;
    const requestObj = {
        walletId: walletId,
    }

    try {
        let response = await this.api.asdf(requestObj);
        
        await this._updateComponent();
        this.setState({loading: false});
        ShowSuccesToast("Fatura u pagua me sukses !");
        this.props.navigation.push('TransactionSuccessful', {vlera: fature.totalAmt, sherbimi: 'asdfasdf'});
        //TODO show transaction details
    } catch (error) {
        this.setState({loading: false});
        this.props.navigation.push('TransactionFailed', {error: error});
        console.log('error' + JSON.stringify(error));

    }
}
@react-native-bot
Copy link
Collaborator

Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety?

👉 Click here if you want to take another look at the Bug Report issue template.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels Jun 26, 2019
@lzj1995822
Copy link

same issue

@stale
Copy link

stale bot commented Nov 10, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 10, 2019
@stale
Copy link

stale bot commented Nov 17, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Nov 17, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Component: Modal Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

3 participants